Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The renderExposedForm() method on ExposedFormPluginBase currently returns a rendered string, as with other handlers, we want this to return a render array. Otherwise theme_views_ui_view_preview_section() calls drupal_render() on a string in this case and therefore returns nothing.
A test should be added to check empty areas and exposed filters are rendered in the preview.
Patch to follow.
Comment | File | Size | Author |
---|---|---|---|
#3 | 2015165-3.patch | 5.85 KB | damiankloip |
#3 | interdiff-2015165-3.txt | 933 bytes | damiankloip |
#1 | 2015165-test-only.patch | 4.33 KB | damiankloip |
#1 | 2015165.patch | 4.94 KB | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedComment #3
damiankloip CreditAttribution: damiankloip commentedNeed to also fix the ExposedFormTest as renderExposedForm() outputs a render array instead of a string. The test-only patch above is still good, and shows the particular failure that it should do.
Comment #4
dawehnerNice stuff!
Comment #5
alexpottCommitted 07c6057 and pushed to 8.x. Thanks!