Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Currently, somewhere along the way, we have broken the way a style plugin decides whether it can use fields.
Steps to reproduce
- Create a new view
- Create a new display for that view (E.g. page)
- Change row plugin type to fields (E.g. from 'Content', 'User', etc.. - entity)
- Fields plugin will be selected ok, but where you would expect to see fields (and link to add them) you will see 'The selected style or row format does not utilize fields.' text.
This should have a UI test to reproduce.
Comment | File | Size | Author |
---|---|---|---|
#21 | d8-views-followup-remove-empty-file-2015999-21.patch | 81 bytes | effulgentsia |
#15 | 2015999-15.patch | 6.97 KB | damiankloip |
#15 | interdiff-2015999-15.txt | 711 bytes | damiankloip |
#14 | 2015999-14.patch | 6.98 KB | damiankloip |
#14 | interdiff-2015999-14.txt | 721 bytes | damiankloip |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedWaaa, sorry. Let's add the usesRowPlugin option to the test style plugin too - so the test is fairer.
Comment #3
damiankloip CreditAttribution: damiankloip commentedForgot about the style plugin test. If we just move around the assertions and setUsesRowPlugin to FALSE instead of TRUE, we should be good for both tests.
Comment #4
Les LimChanging status for tests.
Comment #6
damiankloip CreditAttribution: damiankloip commented#3: 2015999.patch queued for re-testing.
Comment #7
dawehnerShould we also check that $view->rowPlugin is now not an instance of RowTest?
Beside from this, this looks perfect.
Comment #8
damiankloip CreditAttribution: damiankloip commentedYeah. let's do it! I thought we might as well check that it is using the Fields row plugin instead.
Comment #9
dawehnerThank you!
Comment #10
catchI know it's already there, but two cases of 'Take sure' in lines that are changed.
Comment #11
damiankloip CreditAttribution: damiankloip commentedFair point, changed those lines.
Comment #12
dawehnerI'm sorry for all the "take" sure all over the place.
Comment #13
alexpottThis should be something like...
Can the style plugin use row plugins.
Comment #14
damiankloip CreditAttribution: damiankloip commentedYep, sure. Fixed.
Comment #15
damiankloip CreditAttribution: damiankloip commentedErrhhhmm, Let's try that again.
Comment #16
damiankloip CreditAttribution: damiankloip commentedAnd back again.
Comment #17
dawehner+1
Comment #18
alexpottCommitted 62ed405 and pushed to 8.x. Thanks!
Comment #19
effulgentsia CreditAttribution: effulgentsia commentedWhat's this file for?
Comment #20
damiankloip CreditAttribution: damiankloip commentedGood question!
Comment #21
effulgentsia CreditAttribution: effulgentsia commentedIn case it's not there for a reason, here's the patch to remove it.
Comment #22
dawehnerWould be cool to understand what added the file in the first place.
Comment #23
damiankloip CreditAttribution: damiankloip commentedIts a mistake, beyond doubt.
Comment #24
neclimdulLooks like it got added in #8. assume it was just an accident on the command line. things happen and its hard to see in the patch. RTBC for sure. Maybe the first 0 line patch? ;)
Comment #25
alexpottWhoops should have caught that on review... my bad.
Committed f36f480 and pushed to 8.x. Thanks!
Comment #26.0
(not verified) CreditAttribution: commentedUpdated issue summary.