Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#4 drupal-op_helper-to-opHelper-2003550-4.patch1.77 KBheddn
#2 2003550-op_helper-to-addFilter-drupal-2.patch2.15 KBThijsFeryn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ThijsFeryn’s picture

ThijsFeryn CreditAttribution: ThijsFeryn commented
Title: Rename Views method op_contains() to addContains() » Rename Views method op_helper() to addFilter()
ThijsFeryn’s picture

ThijsFeryn CreditAttribution: ThijsFeryn commented
Status: Active » Needs review
FileSize
2003550-op_helper-to-addFilter-drupal-2.patch2.15 KB

Status: Needs review » Needs work

The last submitted patch, 2003550-op_helper-to-addFilter-drupal-2.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Title: Rename Views method op_helper() to addFilter() » Rename Views method op_helper() to opHelper()
Status: Needs work » Needs review
FileSize
drupal-op_helper-to-opHelper-2003550-4.patch1.77 KB

Renaming title, re-rolling to rename as opHelper and adding protected per OOP standards.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f584bd9 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.