Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Let's do this then. I checked again and there's no usage of $_errors in the entirety of core/lib outside of the ones being touched here. In the long run, we probably do want to log this properly, but that should be sorted out on its own.
curl https://drupal.org/files/drupal-postreamreader_get_t-2017345-1.patch | git a
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 8480 100 8480 0 0 4391 0 0:00:01 0:00:01 --:--:-- 6838
error: patch failed: core/lib/Drupal/Component/Gettext/PoStreamReader.php:280
error: core/lib/Drupal/Component/Gettext/PoStreamReader.php: patch does not apply
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedactually it calls get_t
Comment #2
ParisLiakos CreditAttribution: ParisLiakos commentedconverted it to String::format, dunno if its the appropriate solution though since those strings cant be translated now
Comment #3
tstoecklerI wanted to find out where $_errors is used, but couldn't find anything. On top of that, it's declared as private, so... very strange!
Comment #4
Gábor HojtsyAgreed with this change!
It is/was supposed to have an accessor method and the error be logged or something (if used in an already set up environment)?
Comment #5
tstoecklerLet's do this then. I checked again and there's no usage of $_errors in the entirety of core/lib outside of the ones being touched here. In the long run, we probably do want to log this properly, but that should be sorted out on its own.
Comment #6
alexpottNeeds a reroll
Comment #7
pwieck CreditAttribution: pwieck commentedHere is the reroll
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commentedthank you pwieck!
looks good
Comment #9
alexpottCommitted b22c7a5 and pushed to 8.x. Thanks!