Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hansenm’s picture

Assigned: Unassigned » hansenm

I'm working on this at the DrupalCon Portland sprint.

hansenm’s picture

Status: Active » Needs review
FileSize
866 bytes

Status: Needs review » Needs work

The last submitted patch, views-rename-compile_fields-2002428-2.patch, failed testing.

heddn’s picture

Tests failing. Please investigate and re-roll a patch.

daven’s picture

Status: Needs work » Needs review
daven’s picture

Status: Needs review » Needs work

Access modifier needs to be added to the function line as mentioned in the meta issue discussion:
http://drupal.org/node/1856630#comment-7451652

Should be "public function ..."

+++ b/core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.phpundefined
@@ -1189,7 +1189,7 @@ function get_non_aggregates() {
-  function compile_fields($query) {
+ public function compileFields($query) {

heddn’s picture

Status: Needs work » Needs review
FileSize
4.56 KB

Actually, protected seems more appropriate ($this->instantiateView) is the only call. Let's see if it keeps the testbot happy.

heddn’s picture

Let's try the right patch.

dcam’s picture

Status: Needs review » Reviewed & tested by the community

#8 looks good to me. All instances of the instantiate_view() method have been renamed. instantiateView() has been given protected visibility.

I think that #2 was mistakenly posted to the wrong issue. It should have gone into #2002428: Rename Views method compile_fields() to compileFields().

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 7790f21 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.