Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#5 drupal-rename-summary-basics-2002988-5.patch2.72 KBtvlooy
#3 drupal-rename-summary-basics-2002988-3.patch2.72 KBkenianbei
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented

Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Assigned: Unassigned » kenianbei
kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Status: Active » Needs review
FileSize
drupal-rename-summary-basics-2002988-3.patch2.72 KB

First patch for drupal core, whoop!

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs review » Needs work

@kenianbei, thanks for contributing. You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Status: Needs work » Needs review
FileSize
drupal-rename-summary-basics-2002988-5.patch2.72 KB

Added the access modifier.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs review » Reviewed & tested by the community

Looks good.

Reviewed patch based on the following criteria: http://drupal.org/node/1856630#comment-7450696

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 4547223 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.