Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#21 | drupal-viewsRename-add_orderby-2002272-21.patch | 13.68 KB | heddn |
#21 | interdiff.txt | 11.79 KB | heddn |
#17 | 2002272-17.patch | 12.14 KB | jibran |
#6 | 2002272-6-rename-add_order_by.patch | 12.12 KB | elvis2 |
#3 | 2002272-1-rename-add_order_by.patch | 12.11 KB | elvis2 |
Comments
Comment #1
benjifisherFix issue title.
Comment #2
elvis2 CreditAttribution: elvis2 commentedComment #3
elvis2 CreditAttribution: elvis2 commentedNo documentation changes were required.
Comment #4
aspilicious CreditAttribution: aspilicious commentedLooks ok to me
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the method to adher to the new OOP standards.
Comment #6
elvis2 CreditAttribution: elvis2 commented@oenie, thanks!
Comment #8
elvis2 CreditAttribution: elvis2 commented#6: 2002272-6-rename-add_order_by.patch queued for re-testing.
Comment #10
oenie CreditAttribution: oenie commented#6: 2002272-6-rename-add_order_by.patch queued for re-testing.
Comment #12
aspilicious CreditAttribution: aspilicious commented#6: 2002272-6-rename-add_order_by.patch queued for re-testing.
Comment #13
oenie CreditAttribution: oenie commentedLooks good to me now
Except maybe from a very minor comment issue:
core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php, Line 997:
Comment #14
elvis2 CreditAttribution: elvis2 commentedThanks @oenie, I will ask the parent issue what do to about that.
Comment #15
heddnOrdinarily I'd suggest we not make the change from #13 right now. The scope of this issue was to only rename methods. However, this feels like an exception. Go ahead and change the comment to camel case.
Comment #16
alexpottNeeds a re-roll
And lets make the change suggested by #13 to fix up the comment.
Comment #17
jibranReroll
conflict I
resolved
conflict II
resolved
Comment #19
aspilicious CreditAttribution: aspilicious commented#17: 2002272-17.patch queued for re-testing.
Comment #21
heddnre-roll and fixing #13
Comment #22
heddnComment #24
aspilicious CreditAttribution: aspilicious commented#21: drupal-viewsRename-add_orderby-2002272-21.patch queued for re-testing.
Comment #25
aspilicious CreditAttribution: aspilicious commentedDone thnx :)
Comment #26
alexpottCommitted 9c5e4bc and pushed to 8.x. Thanks!