Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comments
Comment #1
chr.fritschComment #2
chr.fritschComment #4
aprice42 CreditAttribution: aprice42 commentedComment #5
chr.fritsch#2: views-Rename_Views_method_get_entity_to_getEntity-2002906-1.patch queued for re-testing.
Comment #6
aprice42 CreditAttribution: aprice42 commentedComment #8
jasonyarrington#2: views-Rename_Views_method_get_entity_to_getEntity-2002906-1.patch queued for re-testing.
Comment #10
heddnComment #11
dawehnerTest failure was random. ... though the patch needs a rerole.
Comment #12
aaronott CreditAttribution: aaronott commentedThis is a reroll of #2
Comment #13
dawehnerYou missed the one on core/modules/node/lib/Drupal/node/Plugin/views/field/RevisionLink.php
Comment #14
aaronott CreditAttribution: aaronott commentedCool... i just ran a grep and grabbed a comment as well, looks like this should cover them all. Thanks!
Comment #16
somepal CreditAttribution: somepal commentedpatch looks good, #14: views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch queued for re-testing.
Comment #17
dawehnerThank you!
Comment #18
somepal CreditAttribution: somepal commentedno problem. reviewed patch and good test result too. gtg with #14 views-Rename_Views_method_get_entity_to_getEntity-2002906-14.patch
Comment #19
webchickSorry, doesn't apply. :(
Comment #20
jibranReroll
Conflict
Resolved
Comment #21
aspilicious CreditAttribution: aspilicious commentedComment #22
alexpottNeeds another reroll
Comment #23
jibranreroll
Comment #25
jibranLet's try one more time.
Comment #27
aspilicious CreditAttribution: aspilicious commented#25: 2002906-25.patch queued for re-testing.
Comment #29
pwieck CreditAttribution: pwieck commentedRe-roll
Comment #30
dawehner@pwieck
You touched a yml file and removed all renames, I don't think this will pass ;)
Comment #31
pwieck CreditAttribution: pwieck commentedRe-roll. Made a nub mistake
Comment #32
heddn@pwieck, the patch #31 seems to be missing function renames that were included #20. And also, the scope of this issue is to simply rename the functions.
No need to rename variables, etc.
Comment #33
pwieck CreditAttribution: pwieck commented@heddn sorry I'm new will try again
Comment #34
pwieck CreditAttribution: pwieck commentedRe-re roll. I hope I got it this time.
Comment #35
aspilicious CreditAttribution: aspilicious commentedLook at the first patches, this one doens't include everything
Comment #36
pwieck CreditAttribution: pwieck commented@aspilicious - I'm a nub. Just to get this straight next time. I take all the 'passed' patches apply them first them search for renames then make patch... Right? I don't want to keep wasting everyones time
Comment #37
pwieck CreditAttribution: pwieck commented@aspilicious - I just read the re-roll docs. Sorry. Will re-roll tonight
Comment #38
chrisguindon CreditAttribution: chrisguindon commentedReroll of comment #20
Comment #39
chrisguindon CreditAttribution: chrisguindon commentedComment #41
pwieck CreditAttribution: pwieck commentedI can't seem to find a point in the commit that #20 works on. It keeps failing on RevisionLink.php. Started on June 4th and worked backwards till June 3rd. Am I doing something wrong?
Comment #42
chrisguindon CreditAttribution: chrisguindon commented#38: views-Rename_Views_method_get_entity_to_getEntity-2002906-38.patch queued for re-testing.
Comment #43
chrisguindon CreditAttribution: chrisguindon commented@pwieck I was able to apply #20 from commit 3a72626107fb906d41de73aed701ca5104a2c550
Comment #45
pwieck CreditAttribution: pwieck commentedMy last try at this re-roll
Comment #46
pwieck CreditAttribution: pwieck commentedHolly Cow! #45 passed
Comment #47
aspilicious CreditAttribution: aspilicious commentedi think this is OK now
Comment #48
alexpottCommitted 2b51e78 and pushed to 8.x. Thanks!