Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#6 drupal-viewsRename-get_channel_elements-2002896-6.patch1.42 KBheddn
#2 2002896.patch1011 byteshoZt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hoZt’s picture

hoZt CreditAttribution: hoZt commented
Assigned: Unassigned » hoZt
hoZt’s picture

hoZt CreditAttribution: hoZt commented
Status: Active » Needs review
FileSize
2002896.patch1011 bytes
SlayJay’s picture

SlayJay CreditAttribution: SlayJay commented
Status: Needs review » Reviewed & tested by the community

reviewed the name changes, looks good.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2002896.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

This feels really like a protected method.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
FileSize
drupal-viewsRename-get_channel_elements-2002896-6.patch1.42 KB

Added protected.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs work » Needs review

Status: Needs review » Needs work
Issue tags: -Novice, -VDC

The last submitted patch, drupal-viewsRename-get_channel_elements-2002896-6.patch, failed testing.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Status: Needs work » Needs review
Issue tags: +Novice, +VDC

#6: drupal-viewsRename-get_channel_elements-2002896-6.patch queued for re-testing.

I ran some of the failed tests locally and they passed so I'm re-queued for the testbot

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Perfect! I think this will maybe dissappear in the future, but yeah let's not think about this possibility for now.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed 281e533 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.