MenuListController, ShortcutListController and RoleListController were obviously based on CategoryListController, but when copy-and-pasting the code the docblocks were not updated. The attached patch fixes this.

CommentFileSizeAuthor
controller-doc-blocks.patch1.55 KBlongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, controller-doc-blocks.patch, failed testing.

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Needs work » Needs review

Somehow I think this test failure was unrelated:

Link with label Test Operation: mA5RTW% found.
EntityOperationsTest.php 54
Drupal\system\Tests\Entity\EntityOperationsTest->testEntityOperationAlter()

controller-doc-blocks.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: Unassigned » jhodgdon
Status: Needs review » Reviewed & tested by the community

Doh! Good catch, and thanks for the patch! I'll get this committed ASAP.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Assigned: jhodgdon » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks again! Committed to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.