Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Files that need converting are:
- core/modules/comment/comment.admin.inc
- core/modules/comment/comment.module
- core/modules/comment/comment.pages.inc
Comment | File | Size | Author |
---|---|---|---|
#5 | 1999340-comment-request-5.patch | 2.17 KB | kim.pepper |
#5 | interdiff.txt | 1.05 KB | kim.pepper |
#1 | 1999340_1-replace-raw-variables-comment.patch | 1.88 KB | chertzog |
Comments
Comment #1
chertzogComment #3
chertzog#1: 1999340_1-replace-raw-variables-comment.patch queued for re-testing.
Comment #4
Crell CreditAttribution: Crell commentedSlight scope creep, but as long as we're in here let's change drupal_container()->get() to Drupal::service('http_kernel').
Comment #5
kim.pepperFix in #4 plus replaced uses of deprecated drupal_container().
Comment #7
kim.pepper"Failed to write configuration file" Re-testing.
Comment #8
kim.pepper#5: 1999340-comment-request-5.patch queued for re-testing.
Comment #9
Crell CreditAttribution: Crell commentedComment #10
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #11
effulgentsia CreditAttribution: effulgentsia commentedShould we remove that @todo now or is there something else needed for that?
Comment #12
Crell CreditAttribution: Crell commentedI think that would require rewriting the pager system, which has needed one for a few years now but still hasn't gotten it. :-(
Comment #13
effulgentsia CreditAttribution: effulgentsia commentedDoes that mean the patch that got committed broke the pager when used on a page with comments? Sorry, I'd check myself, but trying to focus on other issues, so leaving this comment in case someone else wants to investigate.