It would make a good project for someone who is new to the Drupal contribution process. It's preferred over Newbie.
Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().
Will be done today during Code Sprint UA.
Patch attached.
#3 nice work RTBC
#3: book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch queued for re-testing.
The last submitted patch, book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch, failed testing.
Let's try it now.
#7: replace_theme_by_drupal_render-2008974.patch queued for re-testing.
I applied the patch cleanly, tested the book module, and it worked as expected! This seems good to go.
whoops, accidental double post!
@siccababes,
What do you mean by "accidental double post" ? can you please explain?
Committed fa6444e and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
thedavidmeister CreditAttribution: thedavidmeister commentedComment #2
InternetDevels CreditAttribution: InternetDevels commentedWill be done today during Code Sprint UA.
Comment #3
K15.Multik CreditAttribution: K15.Multik commentedPatch attached.
Comment #4
podarok#3 nice work
RTBC
Comment #5
catch#3: book-replace_theme_with_drupal_render_in_book_module-2008974-3.patch queued for re-testing.
Comment #7
drupee CreditAttribution: drupee commentedLet's try it now.
Comment #8
drupee CreditAttribution: drupee commented#7: replace_theme_by_drupal_render-2008974.patch queued for re-testing.
Comment #9
siccababes CreditAttribution: siccababes commentedI applied the patch cleanly, tested the book module, and it worked as expected! This seems good to go.
Comment #10
siccababes CreditAttribution: siccababes commentedwhoops, accidental double post!
Comment #11
drupee CreditAttribution: drupee commented@siccababes,
What do you mean by "accidental double post" ? can you please explain?
Comment #12
alexpottCommitted fa6444e and pushed to 8.x. Thanks!