Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#17 | views-core-rename-ensure-table-2002484-16.patch | 15.22 KB | hussainweb |
#14 | views-core-rename-ensure-table-2002484-14.patch | 15.22 KB | SpartyDan |
#11 | ensure_table_rename-2002484-11.patch | 16.55 KB | heddn |
#8 | ensure_table_rename-2002484-3.patch | 8.24 KB | brennanmh |
#6 | ensure_table_rename-2002484-2.patch | 8.23 KB | brennanmh |
Comments
Comment #1
brennanmh CreditAttribution: brennanmh commented# modified: core/modules/views/lib/Drupal/views/ManyToOneHelper.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/HandlerBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/argument/ManyToOne.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/field/FieldPluginBase.php
# modified: core/modules/views/lib/Drupal/views/Plugin/views/query/Sql.php
# modified: core/modules/views/tests/views_test_data/lib/Drupal/views_test_data/Plugin/views/query/QueryTest.php
#
Comment #3
connorwk CreditAttribution: connorwk commented#1: ensure_table_rename-2002484.patch queued for re-testing.
Comment #5
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the function to adher to the new OOP standards.
Every occurence of NULL, TRUE and FALSE should be uppercase. This patch changed all occurences to lowercase
Comment #6
brennanmh CreditAttribution: brennanmh commentedMy bad. Should have stuck with vi instead of new install of phpStorm.
Anyway, this updated patch should have only the ensure_table() -> ensureTable() change.
Comment #7
oenie CreditAttribution: oenie commentedStill missing that public access modifier though.
Comment #8
brennanmh CreditAttribution: brennanmh commentedThird time's the charm? :)
Comment #10
brennanmh CreditAttribution: brennanmh commentedTook ownership.
Comment #11
heddn#3 won't apply any longer. Here's a reroll.
Comment #12
heddnComment #13
dcam CreditAttribution: dcam commented#11 doesn't apply any longer.
Comment #14
SpartyDan CreditAttribution: SpartyDan commentedre-roll
Comment #16
drupee CreditAttribution: drupee commentedComment #17
hussainwebI have fixed the problem (and tested by installing Drupal and accessing views). I have also rerolled it against the latest tree.
Comment #18
dcam CreditAttribution: dcam commentedSetting status.
Comment #19
aspilicious CreditAttribution: aspilicious commentedComment #20
alexpottCommitted 6345a5c and pushed to 8.x. Thanks!