Hey.

When using this module with Drupal 7, and viewing it on Chrome, I'm seeing the background as flat black. I changed the opacity down to 0.3, but it doesn't actually do anything - My guess is some part of the fade in/face out code is sending the opacity to 1.0 and then it gets stuck there, but I'm not having any luck figuring out where.

CommentFileSizeAuthor
#4 fix_lightbox_opacity-2020057-4.patch478 bytesmajingas
#3 fix_lightbox_opacity-2020057-3.patch518 bytesmajingas
#2 fix_lightbox_opacity-2020057-2.patch590 bytesjcfiala
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented

More data.

1) I'm using the modal ability, so it's lightmodal.

2) It _is_ the fadeIn on line 302:

    if (lightvideo && this.detectMacFF2()) {
      $("#lightbox2-overlay").removeClass("overlay_default");
      $("#lightbox2-overlay").addClass("overlay_macff2");
      $("#lightbox2-overlay").css({'opacity' : null});
    }
    else {
      $("#lightbox2-overlay").removeClass("overlay_macff2");
      $("#lightbox2-overlay").addClass("overlay_default");
      $("#lightbox2-overlay").css({'opacity' : Lightbox.overlayOpacity});
    }
    $("#lightbox2-overlay").fadeIn(Lightbox.fadeInSpeed);

When I replaced that last fadeIn with:

$("#lightbox2-overlay").fadeTo(Lightbox.fadeInSpeed, Lightbox.overlayOpacity);

Everything worked fine. Let's see if I can whack out a quick patch.

jcfiala’s picture

jcfiala CreditAttribution: jcfiala commented
Status: Active » Needs review
FileSize
fix_lightbox_opacity-2020057-2.patch590 bytes

Here we go...

majingas’s picture

majingas CreditAttribution: majingas commented
Issue summary: View changes
FileSize
fix_lightbox_opacity-2020057-3.patch518 bytes

Edit: don't use this patch.

majingas’s picture

majingas CreditAttribution: majingas commented
FileSize
fix_lightbox_opacity-2020057-4.patch478 bytes

Submitting patch that doesn't use sites/all/modules path to work better with makefiles and profiles.