drupal_container() is deprecated, and all calls in the serialization module need to be replaced with Drupal::service(), except for where the module_handler service is requested, which needs to be replaced with Drupal::moduleHandler() (see #1957154)

This task a part of #2001206: Replace drupal_container() with Drupal::service()

CommentFileSizeAuthor
#6 serialization-2014009-6.patch626 byteskgoel
#5 serialization-2014009-5.patch633 byteskgoel
#2 serialization-2014009-2.patch621 byteskgoel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Assigned: Unassigned » kgoel
kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Active » Needs review
FileSize
serialization-2014009-2.patch621 bytes

Status: Needs review » Needs work

The last submitted patch, serialization-2014009-2.patch, failed testing.

ddrozdik’s picture

ddrozdik CreditAttribution: ddrozdik commented

Please use $this->container->get() instead \Drupal::service in tests.

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Needs work » Needs review
FileSize
serialization-2014009-5.patch633 bytes
kgoel’s picture

kgoel CreditAttribution: kgoel commented
FileSize
serialization-2014009-6.patch626 bytes
Crell’s picture

Crell CreditAttribution: Crell commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Easy peasy.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed f7a22ec and pushed to 8.x. Thanks!

kgoel’s picture

kgoel CreditAttribution: kgoel commented
Status: Fixed » Closed (fixed)