Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Now that the instance storage of the controllers has changed. We have alot of duplication. We can refactor this out to just call a generic getController method.
Comment | File | Size | Author |
---|---|---|---|
#15 | 2001012-15.patch | 3.41 KB | damiankloip |
#7 | 2001012-7.patch | 3.41 KB | damiankloip |
#4 | 2001012-4.patch | 2.45 KB | damiankloip |
#4 | interdiff-2001012-4.txt | 796 bytes | damiankloip |
#2 | 2001012-2.patch | 2.99 KB | damiankloip |
Comments
Comment #2
damiankloip CreditAttribution: damiankloip commentedHow about we roll this against the current HEAD, not the one I'm expecting in the future.
Comment #4
damiankloip CreditAttribution: damiankloip commentedForget about the list controller needing the storage controller injected.
Comment #5
dawehnerJust by random guess I would have expected to have the controller type as first parameter/
Comment #6
dawehnerThis certainly needs a full reroll, due to the injection issue.
Comment #7
damiankloip CreditAttribution: damiankloip commentedrerolled.
Comment #8
dawehnerGreat. Thank you!
Comment #10
damiankloip CreditAttribution: damiankloip commented#7: 2001012-7.patch queued for re-testing.
Comment #12
damiankloip CreditAttribution: damiankloip commented#7: 2001012-7.patch queued for re-testing.
Comment #13
dawehnerComment #14
alexpottNeeds a reroll...
Comment #15
damiankloip CreditAttribution: damiankloip commentedRerolled.
Comment #16
dawehnerAnother one!
Comment #17
alexpottCommitted 9dabd6d and pushed to 8.x. Thanks!