Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#8 drupal-viewsRename-add_where_expression-2002344-8.patch15.76 KBheddn
#6 drupal-viewsRename-add_where_expression-2002344-6.patch14.43 KBheddn
#4 2002344-4-rename-add_where_expression.patch14.46 KBelvis2
#2 2002344-2-rename-add_where_expression.patch14.34 KBelvis2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Assigned: Unassigned » elvis2
elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Active » Needs review
FileSize
2002344-2-rename-add_where_expression.patch14.34 KB
oenie’s picture

oenie CreditAttribution: oenie commented
Status: Needs review » Needs work

This one as well, good work !
Unfortunately we need a reroll, the patch doesn't apply anymore.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs work » Needs review
FileSize
2002344-4-rename-add_where_expression.patch14.46 KB

Re-rolled

Status: Needs review » Needs work

The last submitted patch, 2002344-4-rename-add_where_expression.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs work » Needs review
FileSize
drupal-viewsRename-add_where_expression-2002344-6.patch14.43 KB

Previous patch wouldn't apply. Let's try this one.

Status: Needs review » Needs work

The last submitted patch, drupal-viewsRename-add_where_expression-2002344-6.patch, failed testing.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented
Status: Needs work » Needs review
FileSize
drupal-viewsRename-add_where_expression-2002344-8.patch15.76 KB

Seems I missed a rename in core/modules/views/lib/Drupal/views/Plugin/views/filter/Date.php

Let's see how we fair this time.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Committed fc1bd6f and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.