Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards

CommentFileSizeAuthor
#10 view-rename_method-2002974-10.patch6.18 KBdanylevskyi
#7 VDC-Rename_render_text-2003328-5.patch2.4 KBtvlooy
#5 drupal-rename-title-query-2002974-5.patch6.18 KBtvlooy
#2 drupal-rename-title-query-2002974-2.patch6.11 KBkenianbei
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Assigned: Unassigned » kenianbei
kenianbei’s picture

kenianbei CreditAttribution: kenianbei commented
Status: Active » Needs review
FileSize
drupal-rename-title-query-2002974-2.patch6.11 KB
elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs review » Needs work

You need to add the access modifier (public/private/protected) before the function name. Take a look at the parent issue (http://drupal.org/node/1856630), comments #28, #34, #35 for more details.

You can see an example patch here: http://drupal.org/node/2001672

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Assigned: kenianbei » tvlooy

Work in progress

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
FileSize
drupal-rename-title-query-2002974-5.patch6.18 KB

Added the access modifiers.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
Assigned: tvlooy » Unassigned
Status: Needs work » Needs review

Added the access modifiers.

tvlooy’s picture

tvlooy CreditAttribution: tvlooy commented
FileSize
VDC-Rename_render_text-2003328-5.patch2.4 KB

Wrong post. Please ingore. #5 is the correct one.

elvis2’s picture

elvis2 CreditAttribution: elvis2 commented
Status: Needs review » Needs work

@tvlooy Please resubmit the correct patch. This will reduce confusion for the person who is approving the patches to be moved into core.

Thanks

danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi commented
Assigned: Unassigned » danylevskyi
Issue tags: +CodeSprintUA
danylevskyi’s picture

danylevskyi
Location Myrhorod / Ukraine
CreditAttribution: danylevskyi commented
Assigned: danylevskyi » Unassigned
Status: Needs work » Needs review
FileSize
view-rename_method-2002974-10.patch6.18 KB
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
CreditAttribution: podarok commented
Status: Needs review » Reviewed & tested by the community

#10 nice conversion
RTBC

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn commented

Applies cleanly and all occurrences of title_query are now changed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: Rename Views method title_query() to titleQuery() » Change notice: Rename Views method title_query() to titleQuery()
Project: Drupal core » Views (for Drupal 7)
Version: 8.x-dev » 8.x-3.x-dev
Component: views.module » Code
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed and pushed to 8.x. Thanks!

Moving to the Views queue for the change notice.

xjm’s picture

xjm
she/her
Primary language English
CreditAttribution: xjm commented
Title: Change notice: Rename Views method title_query() to titleQuery() » Rename Views method title_query() to titleQuery()
Project: Views (for Drupal 7) » Drupal core
Version: 8.x-3.x-dev » 8.x-dev
Component: Code » views.module
Status: Active » Fixed
Issue tags: -Needs change record

Single change notice in the meta.

Automatically closed -- issue fixed for 2 weeks with no activity.