Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vijaycs85’s picture

Issue tags: +Quick fix
FileSize
455 bytes

Initial patch...

Currently it is failing few test cases in #1952394-45: Add configuration translation user interface module in core

vijaycs85’s picture

Status: Active » Needs review
Issue tags: -Quick fix
vijaycs85’s picture

Issue tags: +Quick fix
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Oh right I should have spotted that.

tim.plunkett’s picture

Do we want to fix it in these as well?

  • core/modules/tracker/tests/modules/tracker_test_views/test_views/views.view.test_tracker_user_uid.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_display_arguments.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_view.yml
  • core/modules/views/tests/views_test_config/test_views/views.view.test_page_display_route.yml
YesCT’s picture

We are still getting exceptions,
341 passes, 0 fails, 4 exceptions, and 118 debug messages,
in config_translation (with these applied:
#2020867: Update contact module URL in test cases.
#2020347: Temporary fix for config_translation_enter_context until language context becomes an option
#2020343: remove instance of locale_storage()
#2020859: Change the occurance of 'human_name' to 'label' in views configuration & schema
)
http://screencast.com/t/vizSwnFKL
Undefined index: source
http://screencast.com/t/s4Oh3E8lTbUb

I'm not sure if those are causing the exceptions through. Or totally unrelated.

Note, #1952394: Add configuration translation user interface module in core will add tests that rely on schema so provides some test coverage of schema.

vijaycs85’s picture

Title: Change 'human_name' to 'label' in views schema » Change the occurance of 'human_name' to 'label' in views configuration & schema
Status: Reviewed & tested by the community » Needs review
FileSize
2.38 KB
2.82 KB

Yes, Updated them all and title to reflect the patch changes... back to 'Needs review'.

YesCT’s picture

Oh, I see. sorry, those were config changes just for human name still, nothing else.
Which probably answers my question that it's not related to the other exceptions.

---
with patch applied,
$ ag human_name core
core/modules/field_ui/lib/Drupal/field_ui/DisplayOverview.php
150: 'human_name' => array(
334: 'human_name' => array(

So no more human_name in views.
Changes look good to me.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community
webchick’s picture

Status: Reviewed & tested by the community » Needs work

Looks simple enough, but no longer applies.

tim.plunkett’s picture

Title: Change the occurance of 'human_name' to 'label' in views configuration & schema » Change the occurance of 'human_name' to 'label' in views configuration & schema
Status: Needs work » Needs review
FileSize
2.92 KB

Was just a new directory added.

Status: Needs review » Needs work
Issue tags: -Quick fix, -VDC

The last submitted patch, vdc-2020859-11.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +Quick fix, +VDC

#11: vdc-2020859-11.patch queued for re-testing.

YesCT’s picture

Status: Needs review » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Can confirm there are no traces of human_name in views, views_ui or any views YAML...

Committed 5356a24 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.