Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
This function was introduced in #1552396: Convert vocabularies into configuration as temporary
Drop it once we get tests back in #1799600: Add test of sorting for configuration entities and #1893442: Move BlockStorageController::loadByProperties() into ConfigStorageController
Comment | File | Size | Author |
---|---|---|---|
#28 | 1981418-voc-sort-28.patch | 3.92 KB | andypost |
#24 | taxonomy-1981418-24.patch | 3.72 KB | tim.plunkett |
Comments
Comment #1
andypostLet's see how bots will pass...
Extended test would be reverted in #1893442-6: Move BlockStorageController::loadByProperties() into ConfigStorageController
Comment #2
andypostChanged comparison to allow debug also I think this easy to understand
Comment #3
andypostWas wrong patch (locally pass randomly)
Comment #5
andypostThis bug also affects in #1868772-86: Convert filters to plugins
Comment #6
alphawebgroup#3: 1981418-voc-sort-2.patch queued for re-testing.
Comment #7
alphawebgroup#3: 1981418-voc-sort-2.patch queued for re-testing.
Comment #8
alphawebgroup#3: 1981418-voc-sort-2.patch queued for re-testing.
Comment #9
alphawebgroup#3: 1981418-voc-sort-2.patch queued for re-testing.
Comment #11
alphawebgroupre-rolling
Comment #13
javisr CreditAttribution: javisr commented#11: 1981418-voc-sort-3.patch queued for re-testing.
Comment #15
andypostpatch needs re-roll
Comment #16
dsdeiz CreditAttribution: dsdeiz commentedRe-rolling. Didn't test locally thought. Can't get simpletest to work. I'll probably give the bot a try.
OT: How do I create an interdiff when re-rolling patches?
Comment #18
pcambraIgnore this patch
Comment #19
pcambraHere's a re-roll with a minor fix on taxonomy load, it should pass now.
Comment #21
pwieck CreditAttribution: pwieck commentedRemoving tag. Still applies to current head
Comment #22
andypost#19: 1981418-19-voc-sort.patch queued for re-testing.
Comment #24
tim.plunkettThat failing assertion is useless. It tests a behavior that doesn't exist. It just arbitrarily sorts and tests the arbitrary sort.
Comment #25
andypostRemoval of the test means that we have no tests for default sorting order for configurables
ConfigEntityListController::load()
#1893442: Move BlockStorageController::loadByProperties() into ConfigStorageController added the check for
load_by_properties()
Also that means that out default sorting for configurables is fragile
Patch in #3 shows that this leads to random failures, so I cant rtbc it
Comment #26
tim.plunkettThe testing for default ordering belongs with config_test then, lets move the coverage there.
Comment #27
vijaycs85Updating tags, as it doesn't sounds like novice issue anymore.
Comment #28
andypostThe function is not used and sorting happens in list controller so re-roll of last patch
Comment #29
xjmNo real need for a change record here since the function didn't exist in D7.
Comment #30
catchCommitted/pushed to 8.x, thanks!