Part of #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase
here's a first pass at this one
+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Form/CustomBlockTypeDeleteForm.php @@ -0,0 +1,80 @@ + $blocks = \Drupal::entityQuery('custom_block')->condition('type', $this->blockType->id())->execute();
We should be able to inject the query factory here rather than calling \Drupal::
here's another pass implementing ControllerInterface and using query factory
The last submitted patch, 2022415-custom-block-type-confirm-delete-form-3.patch, failed testing.
here's another go using EntityConfirmFormBase instead of ConfirmFormBase, since custom_block is an entity
adding use QueryFactory statement to pass tests
This is good to go
Committed and pushed to 8.x. Thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.
Comments
Comment #1
bdone CreditAttribution: bdone commentedhere's a first pass at this one
Comment #2
Crell CreditAttribution: Crell commentedWe should be able to inject the query factory here rather than calling \Drupal::
Comment #3
bdone CreditAttribution: bdone commentedhere's another pass implementing ControllerInterface and using query factory
Comment #5
bdone CreditAttribution: bdone commentedhere's another go using EntityConfirmFormBase instead of ConfirmFormBase, since custom_block is an entity
Comment #6
bdone CreditAttribution: bdone commentedadding use QueryFactory statement to pass tests
Comment #7
dawehnerThis is good to go
Comment #8
webchickCommitted and pushed to 8.x. Thanks!