Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dromansab’s picture

Is this issue solved in new version of the module?

I've a customer who is is strongly emphasizing on this theme ;-)

Thanks!

quicksketch’s picture

The first row contains the full title of the Webform node.
The second row contains the title of any combination elements that have multiple columns, including grid components and select lists.
The third row contains the the title of any simple elements like text fields, or in the case of multi-element fields like grid and select lists, the labels for individual options.

So I could see you wanting to remove the first line since it doesn't contain anything else other than the title, but the second line is quite useful if you start exporting complicated elements.

Unfortunately these first lines are not changeable. We added hooks to override the output of individual component's CSV data at #1533408: Allow modules to modify exported submissions, but that won't help with the node title being added to the first line. In the 8 years of Webform's history though, no one has found this to be particular problem. I'm not sure if we need to offer the flexibility to remove it, but if there's a suggestion that is easy enough to implement we would consider it.

quicksketch’s picture

Status: Active » Closed (won't fix)

Closing after lack of activity.

jadsay’s picture

This patch provide the ability to remove the submission info above the csv header. Applies on 7.x-4.x.

jadsay’s picture

Version: 7.x-3.9 » 7.x-4.x-dev
Category: Support request » Feature request
Status: Closed (won't fix) » Needs review
jadsay’s picture

The last submitted patch, 4: webform-remove_submission_info-293908-4.diff, failed testing. View results

Liam Morland’s picture

Thanks for the patch. Please check your coding standards. It would be great for this to have a test. Is there a reason it sets $header[0] and $header[1] then unsets them? Could it not just not set them?

Chris Matthews’s picture

Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +Needs tests

@jadsay, Is there a reason it sets $header[0] and $header[1] then unsets them? Could it not just not set them?

webform-remove_submission_info-1886842-6.diff:10: trailing whitespace.
  
webform-remove_submission_info-1886842-6.diff:21: trailing whitespace.
  
webform-remove_submission_info-1886842-6.diff:39: trailing whitespace.
          unset($header[1]);     
webform-remove_submission_info-1886842-6.diff:40: trailing whitespace.
        }        

Checking patch includes/webform.report.inc...
Hunk #1 succeeded at 498 (offset 11 lines).
Hunk #2 succeeded at 854 (offset 13 lines).
Hunk #3 succeeded at 1077 (offset 18 lines).
Applied patch includes/webform.report.inc cleanly.
warning: 4 lines add whitespace errors.