Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#23 | views-rename_can_build_group-2002416-23.patch | 1.32 KB | JeroenT |
#19 | 2002416-rename-can_build_group.patch | 1.32 KB | sillygwailo |
#17 | rename-can_build_group-views-2002416-17.patch | 1.31 KB | mari3.14 |
#15 | 2002416-rename-can_build_group.patch | 1.32 KB | sillygwailo |
#14 | 2002416-14.patch | 0 bytes | jibran |
Comments
Comment #1
heddnComment #2
sillygwailoTaking this with baldwinlouie.
Comment #3
sillygwailoPatch attached, no testing done, method only appears in one place.
Comment #4
dawehnerThis should be marked as protected
These are the only places the method is used.
Comment #6
sillygwailoRe-rolled as protected.
Comment #8
JeroenTrename can_build_group to canBuildGroup.
Comment #9
JeroenTmarking as needs review.
Comment #11
mari3.14 CreditAttribution: mari3.14 commentedPatch re-rolled, tested locally, let's see if I am lucky
Comment #12
oenie CreditAttribution: oenie commentedLooks good to me now !
Comment #13
alexpottNeeds a re-roll
Comment #14
jibranReroll
Conflict
Resloved
Comment #15
sillygwailoEmpty patch? Re-rolled.
Comment #17
mari3.14 CreditAttribution: mari3.14 commentedRe-rolling the patch following suggestions
[I am learning about patching but I do not think this is going to be the one; I am happy to try again if someone tells me what needs changing please]
Comment #18
dawehnerShould be a protected method.
Comment #19
sillygwailoRe-rolled with protected.
Comment #20
sillygwailoComment #22
dawehnerYou made a typo here: Should be canBuildGroup instead
Comment #23
JeroenTRenamed can_build_group to canBuildGroup. Added protected access modifier as mentioned by dawehner.
Comment #24
dawehnerSeems fine.
Comment #25
alexpottCommitted 7d31103 and pushed to 8.x. Thanks!