Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
On issues like #1935300: Don't hardwire Database in Views filters, add regexp to DBTNG it became clear that you want to construct the dbtng query object
a bit earlier.
Comment | File | Size | Author |
---|---|---|---|
#14 | 1937414-14.patch | 8.16 KB | jibran |
#14 | interdiff.txt | 1.9 KB | jibran |
#11 | interdiff.txt | 2.99 KB | jibran |
#7 | views-make-select-objection-earlier-available-1937414-5.patch | 4.66 KB | pwieck |
#8 | views-make-select-objection-earlier-available-1937414-5.patch | 4.66 KB | pwieck |
Comments
Comment #1
dawehnerLet's give it a try.
Comment #2
dawehner#1: drupal-1937414-1.patch queued for re-testing.
Comment #3
tim.plunkettThis is all internal reshuffling, and it makes sense.
Comment #4
alexpottNeeds a reroll
Comment #5
pwieck CreditAttribution: pwieck commentedWorking on reroll now.
Comment #6
pwieck CreditAttribution: pwieck commentedRe-rolled. No conflicts with head.
Comment #7
pwieck CreditAttribution: pwieck commented-DISREGARD- Forgot to change status.
Comment #8
pwieck CreditAttribution: pwieck commentedForgot to change status.
Comment #9
pwieck CreditAttribution: pwieck commentedRe-roll #8 passed. Needs review. Disregard #6 and #7. I never forgot status before and then made a mess of it.
Comment #10
dawehnerThis line should be {@inheritdoc}
It should be even possible to inject the database connection in the constructor?
Comment #11
jibranFixed #10.
Comment #12
dawehnerSo what about the database connection?
Comment #14
jibranImplemented Serializable as per @dawehner suggestion.
we can't inject because we can't specify database connection.
Comment #15
dawehnerThe general idea is to not store the database connection in the serialized object, but remove it in serialize() and add it back in unserialize().