Support from Acquia helps fund testing for Drupal Acquia logo

Comments

baldwinlouie’s picture

Assigned: Unassigned » baldwinlouie

taken by baldwinlouie and sillygwilo

baldwinlouie’s picture

Status: Active » Needs review
FileSize
1.33 KB

attaching patch

baldwinlouie’s picture

rerolling with access modifier

Status: Needs review » Needs work

The last submitted patch, drupal-camelcase-replace-2002488.3.patch, failed testing.

heddn’s picture

Failing tests. Please test and re-roll.

baldwinlouie’s picture

rerolling patch. This one passed testing on my local.

baldwinlouie’s picture

Status: Needs work » Needs review

changing status

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Great!

somepal’s picture

Status: Reviewed & tested by the community » Patch (to be ported)

reviewed.we are good!

somepal’s picture

aspilicious’s picture

Status: Patch (to be ported) » Reviewed & tested by the community
alexpott’s picture

Status: Reviewed & tested by the community » Needs work

Needs reroll

curl https://drupal.org/files/drupal-camelcase-replace.2002488.6.patch | git a
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  1371  100  1371    0     0   1774      0 --:--:-- --:--:-- --:--:--  2285
error: patch failed: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php:103
error: core/modules/views/lib/Drupal/views/Plugin/views/argument/ArgumentPluginBase.php: patch does not apply
error: patch failed: core/modules/views/lib/Drupal/views/ViewExecutable.php:899
error: core/modules/views/lib/Drupal/views/ViewExecutable.php: patch does not apply
jibran’s picture

Status: Needs work » Needs review
FileSize
1.34 KB

reroll

somepal’s picture

Status: Needs review » Reviewed & tested by the community

reviewed.gtg

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 92030a2 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.