Part of #1945406: [meta] Convert all of confirm_form() to ConfirmFormBase

CommentFileSizeAuthor
#6 2022415-custom-block-type-confirm-delete-form-6.patch7.94 KBbdone
#5 2022415-custom-block-type-confirm-delete-form-5.patch7.9 KBbdone
#3 2022415-custom-block-type-confirm-delete-form-3.patch7.43 KBbdone
#1 2022415-custom-block-type-confirm-delete-form-1.patch6.7 KBbdone
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Active » Needs review
FileSize
2022415-custom-block-type-confirm-delete-form-1.patch6.7 KB

here's a first pass at this one

Crell’s picture

Crell CreditAttribution: Crell commented 
+++ b/core/modules/block/custom_block/lib/Drupal/custom_block/Form/CustomBlockTypeDeleteForm.php
@@ -0,0 +1,80 @@
+    $blocks = \Drupal::entityQuery('custom_block')->condition('type', $this->blockType->id())->execute();

We should be able to inject the query factory here rather than calling \Drupal::

bdone’s picture

bdone CreditAttribution: bdone commented
FileSize
2022415-custom-block-type-confirm-delete-form-3.patch7.43 KB

here's another pass implementing ControllerInterface and using query factory

Status: Needs review » Needs work

The last submitted patch, 2022415-custom-block-type-confirm-delete-form-3.patch, failed testing.

bdone’s picture

bdone CreditAttribution: bdone commented
Status: Needs work » Needs review
FileSize
2022415-custom-block-type-confirm-delete-form-5.patch7.9 KB

here's another go using EntityConfirmFormBase instead of ConfirmFormBase, since custom_block is an entity

bdone’s picture

bdone CreditAttribution: bdone commented
FileSize
2022415-custom-block-type-confirm-delete-form-6.patch7.94 KB

adding use QueryFactory statement to pass tests

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

This is good to go

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.