Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We no longer need to prefix border-radius or box-shadow.
http://caniuse.com/border-radius
http://caniuse.com/css-boxshadow
Comment | File | Size | Author |
---|---|---|---|
#20 | remove-prefixed-css-2005520-20.patch | 8.92 KB | echoz |
#12 | remove-prefixed-css-2005520-12.patch | 8.37 KB | echoz |
#10 | remove-prefixed-css-2005520-10.patch | 8.37 KB | echoz |
#8 | remove-prefixed-css-2005520-8.patch | 5.36 KB | echoz |
#3 | remove-prefixed-css-2005520-3.patch | 6.12 KB | echoz |
Comments
Comment #1
echoz CreditAttribution: echoz commentedThis patch removes remaining prefixed border-radius and prefixed box-shadow found in Seven and views-admin.theme.css
Comment #2
echoz CreditAttribution: echoz commentedtagging
Comment #3
echoz CreditAttribution: echoz commentedRe-submitting since stuck at "postponed" after 7hrs, where later patches were queued normally.
Comment #4
LewisNyman#3: remove-prefixed-css-2005520-3.patch queued for re-testing.
Comment #6
LewisNyman#3: remove-prefixed-css-2005520-3.patch queued for re-testing.
Comment #8
echoz CreditAttribution: echoz commentedRe-roll
Comment #9
LewisNymanI found a few more instances of prefixed properties. I don't think we can touch the joyride.css, you could submit an issue in the Github repo. I have no idea about simpletest but I'm sure we can loose it there as well.
Comment #10
echoz CreditAttribution: echoz commentedThanks Lewis. This patch adds the 3 files you noted from simpletest. I also deleted the MS filter lines as IE9 supports box shadow, MS filter no longer needed.
That ie.css (shudder), I spotted that recently, and it can go. Needs another issue, although unrelated to this one.
Comment #12
echoz CreditAttribution: echoz commentedOoops, patching that optimized file got me.
Comment #14
echoz CreditAttribution: echoz commented#12: remove-prefixed-css-2005520-12.patch queued for re-testing.
Comment #15
echoz CreditAttribution: echoz commentedis the optimized file, css_input_with_import.css.optimized.css, a generated file so perhaps we're not supposed to patch it?
Comment #16
LewisNymanI spoke to Berdir about this on IRC, it sounds like we should be patching the optimised file. The CSS files are tests to check to see if the unoptimised CSS comes back correctly once it's optimised. If we change the unoptimised we should change the optimised to match.
Comment #17
echoz CreditAttribution: echoz commentedOk, thanks for checking on that. It is patched in #12 and it came back green.
Comment #18
LewisNymanFantastic, may I suggest we add a section on prefixed properties to our coding standards?
Comment #19
alexpottWe still have some usages of
-webkit-box-shadow
and-moz-box-shadow
in ckeditor.admin.css and seven's ie.css (why they're in ie.css is kinda beyond me :D )Comment #20
echoz CreditAttribution: echoz commentedGee, I don't know what process I began searching for these properties with, but it sure needed some work, thanks @LewisNyman and @alexpott. This patch adds ckeditor.admin.css. I believe we could follow up with prefixed gradients http://lea.verou.me/2013/04/can-we-get-rid-of-gradient-prefixes/ which might need discussion where our line is.
I'm creating another issue to delete seven's ie.css.
Comment #21
echoz CreditAttribution: echoz commentedCreated #2021073: Remove Seven's ie.css
Comment #23
echoz CreditAttribution: echoz commented#20: remove-prefixed-css-2005520-20.patch queued for re-testing.
Comment #25
echoz CreditAttribution: echoz commented#20: remove-prefixed-css-2005520-20.patch queued for re-testing.
Comment #26
LewisNymanThanks Alex, I thought the ckeditor CSS was part of the ckeditor plugin.
Did a global grep for -webkit- prefixes. The only places that -webkit-border-radius or -webkit-box-shadow show up are in third party libs.
Comment #27
alexpottCommitted 6d8aacf and pushed to 8.x. Thanks!
Comment #28
Wim LeersWhy were lines with those properties in
core/modules/simpletest/files/css_test_files/*
removed? They were there to guarantee that CSS aggregation wouldn't break them, and it's entirely possible that sites which need to support older browsers still want to use these.Comment #29
echoz CreditAttribution: echoz commented@Wim Leers, I assume you mean the "filter" and "-ms-filter". I noted removing them in #10. They are obsolete proprietary MS code, although I don't know the nuances of simpletest. Do we need to revert and re-patch leaving them in? If that's the case, it seems like we don't want to remove anything from simpletest, as it's more likely someone would still use the much more modern -webkit-border-radius.
Comment #30
LewisNymanComment #31
sqndr CreditAttribution: sqndr commentedThere's a new issue, #1664268 to remove the remaining vendor prefixes. Closing this one, since the latest patch is outdated as well.