Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Assigned: Unassigned » tim.plunkett

Might be interesting.

tim.plunkett’s picture

Status: Active » Needs review
FileSize
6.35 KB

Status: Needs review » Needs work
Issue tags: -FormInterface

The last submitted patch, shortcut-1978970-2.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review

#2: shortcut-1978970-2.patch queued for re-testing.

tim.plunkett’s picture

#2: shortcut-1978970-2.patch queued for re-testing.

tim.plunkett’s picture

#2: shortcut-1978970-2.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +FormInterface

The last submitted patch, shortcut-1978970-2.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
6.82 KB

Reroll

Crell’s picture

Status: Needs review » Needs work
+++ b/core/modules/shortcut/lib/Drupal/shortcut/Controller/ShortcutController.php
@@ -27,26 +39,58 @@ class ShortcutController implements ControllerInterface {
+      drupal_goto();

This function has been expunged. Return an appropriate redirect object instead.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
7.05 KB

Had to reroll anyway, the drupal_goto was swapped out for return new RedirectResponse(url('<front>', array('absolute' => TRUE)));

Crell’s picture

url()? No generator? Generator please. :-)

tim.plunkett’s picture

FileSize
2.57 KB
7.61 KB

Yeah yeah :)

tim.plunkett’s picture

Issue tags: +WSCCI-conversion

Taggin.

Status: Needs review » Needs work
Issue tags: -FormInterface, -WSCCI-conversion

The last submitted patch, shortcut-1978970-12.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +FormInterface, +WSCCI-conversion

#12: shortcut-1978970-12.patch queued for re-testing.

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Thank you. :-)

dawehner’s picture

Status: Reviewed & tested by the community » Needs review
+++ b/core/modules/shortcut/shortcut.routing.ymlundefined
@@ -25,3 +25,10 @@ shortcut_set_edit:
+    _content: 'Drupal\shortcut\Controller\ShortcutController::addShortcutLinkInline'

_controller is probably enough, as we just redirect.

tim.plunkett’s picture

FileSize
621 bytes
7.61 KB

Made that change

Crell’s picture

Status: Needs review » Reviewed & tested by the community

Bot can disagree if it wants.

dawehner’s picture

back to RTBC

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4852362 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.