Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#9 | 2002274-9-rename-add_relationship.patch | 8.33 KB | elvis2 |
#8 | 2002274-8-rename-add_relationship.patch | 103.56 KB | elvis2 |
#5 | 2002274-5-rename-add_relationship.patch | 8.53 KB | elvis2 |
#2 | 2002274-1-rename-add_relationship.patch | 8.52 KB | elvis2 |
Comments
Comment #1
elvis2 CreditAttribution: elvis2 commentedComment #2
elvis2 CreditAttribution: elvis2 commentedComment #3
valthebaldMissing replacement of QueryPluginBase::add_signature in core/modules/views/lib/Drupal/views/Plugin/views/query/QueryPluginBase.php
Comment #4
oenie CreditAttribution: oenie commentedAdd public access modifier in front of the method to adher to the new OOP standards.
Comment #5
elvis2 CreditAttribution: elvis2 commentedAdded access modifier.
Comment #6
oenie CreditAttribution: oenie commentedLooks fine by me now !
Comment #7
alexpottI think we should be removing the commented out lines of code. That's why we have a SCM.
Comment #8
elvis2 CreditAttribution: elvis2 commentedRe-rolled removing commented out lines and renamed add_relationship().
Comment #9
elvis2 CreditAttribution: elvis2 commentedArggg, sorry about the last patch, I rolled it without "git rest --hard"...
Re-roll of #8.
Comment #11
star-szr#9: 2002274-9-rename-add_relationship.patch queued for re-testing.
Comment #12
aspilicious CreditAttribution: aspilicious commentedComment #13
alexpottCommitted 18e0327 and pushed to 8.x. Thanks!