Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
See:
// These are usually added from system_init() -except maintenance.css.
Needs to be updated or removed
Comment | File | Size | Author |
---|---|---|---|
#8 | drupal-reference-to-system-init-2023093-8.patch | 831 bytes | nesta_ |
#6 | drupal-reference-to-system-init-2023093-6.patch | 807 bytes | nesta_ |
#6 | drupal-reference-to-system-init-2023093-6.interdiff.txt | 733 bytes | nesta_ |
#4 | drupal-reference-to-system-init-2023093-4.patch | 808 bytes | giammi |
#4 | drupal-reference-to-system-init-2023093-4.interdiff.txt | 734 bytes | giammi |
Comments
Comment #1
jhodgdonThanks for the report! I used grep and found that these are normally now added in system_page_build().
So, sounds like a good novice project to fix up this code comment -- oh, I see you've already tagged the issue. :)
Comment #2
nesta_ CreditAttribution: nesta_ commentedI searched the string and is not used for what I chose to delete this comment, because the cast was obsolete information.
A greeting!
Comment #3
jhodgdonBut... Those CSS files are normally added by system_page_build(), as noted in comment #1. Why not change the code comment to say that?
Comment #4
giammi CreditAttribution: giammi commentedtrying...
Comment #5
jhodgdonThanks! This patch is better... but there are a couple of issues:
- The information in the original comment "except maintenance.css" was lost.
- There is a space at the end of the first line. If you plan to work on Drupal patches (and I hope you will continue!) see if you can either set up your editor to remove spaces at the end of lines, or at least highlight them.
Comment #6
nesta_ CreditAttribution: nesta_ commentedtry :)
Comment #7
nesta_ CreditAttribution: nesta_ commentedforget change status sorry.
Comment #8
nesta_ CreditAttribution: nesta_ commentedadd "-except maintenance.css."
:)
Comment #9
giammi CreditAttribution: giammi commentedThanks for your feedback.
Comment #10
penyaskitoAfter feedback has been addressed I think we can RTBC this one.
Comment #11
jhodgdonThanks! Committed to 8.x.