Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Part of meta-issue #1856630: [Change notice] [META] Rename Views methods to core standards
Comment | File | Size | Author |
---|---|---|---|
#15 | drupal-viewsRename-set_items_per_page-2003282-15.patch | 4.45 KB | heddn |
#15 | interdiff.txt | 570 bytes | heddn |
#10 | 2003282-rename-set_items_per_page.patch | 3.77 KB | sillygwailo |
#7 | rename-set-items-per-page-2003282-7.patch | 3.81 KB | theladebug |
#5 | rename-set-items-per-page-2003282.patch | 3.81 KB | theladebug |
Comments
Comment #1
theladebug CreditAttribution: theladebug commentedComment #2
theladebug CreditAttribution: theladebug commentedComment #4
heddnComment #5
theladebug CreditAttribution: theladebug commentedComment #7
theladebug CreditAttribution: theladebug commentedchanged function visibility to public
Comment #9
sillygwailoThis issue is related to #2002920: Rename Views method get_items_per_page() to getItemsPerPage() and that issue should maybe get resolved before this one, where references to
get_items_per_page()
for this patch are changed togetItemsPerPage()
(i.e. a manual merge conflict resolution might be necessary).Comment #10
sillygwailoHere's a re-roll now that #2002920: Rename Views method get_items_per_page() to getItemsPerPage() has been committed.
Comment #12
SpartyDan CreditAttribution: SpartyDan commented#10: 2003282-rename-set_items_per_page.patch queued for re-testing.
Comment #14
drupee CreditAttribution: drupee commentedComment #15
heddnSwitched to public. Let's see if that makes the testbot happy.
Comment #16
drupee CreditAttribution: drupee commented#15: drupal-viewsRename-set_items_per_page-2003282-15.patch queued for re-testing.
Comment #17
dawehnerThere we go! No other instances left.
Comment #18
alexpottCommitted b69a5af and pushed to 8.x. Thanks!