Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Reference from : #255795: Add CAPTCHA to all forms by default
"The attached patch causes the module to add the default CAPTCHA to any form not listed on the CAPTCHA configuration page."
Comment | File | Size | Author |
---|---|---|---|
#17 | add-captcha-to-all-forms-2025181-17.patch | 2.95 KB | fnuppy |
|
Comments
Comment #1
wundo CreditAttribution: wundo commentedHow does this relates with the patch I've just committed for the 7.x branch?
Comment #2
elachlan CreditAttribution: elachlan commentedIt still needs work I think. I will get around to it eventually.
The patch will need to be re-rolled to the 8.x branch.
Comment #3
elachlan CreditAttribution: elachlan commentedPort from git, see issue: #255795: Add CAPTCHA to all forms by default.
Will roll patch soon.
Comment #4
naveenvalechaSee issue for 7,x #255795: Add CAPTCHA to all forms by default
Comment #5
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedComment #6
ddrozdik CreditAttribution: ddrozdik as a volunteer commentedHere is a patch which adds needed feature. This patch does not have any tests, since all tests for the settings form will be added here https://www.drupal.org/node/2802617
Comment #7
nirvana_u CreditAttribution: nirvana_u as a volunteer and for Faichi Solutions Pvt Ltd commentedHi @ddrozdik,
Thanks for looking into this. I have applied the patch on my d8 environment with captcha (8.x-1.x-dev) version. But unable to get positive result. This needs to be re-work.
Please let me know if more clarity needed and we can discuss further.
Hope this helps.
Thanks & Regards!!!
Comment #8
Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commentedComment #9
fnuppy CreditAttribution: fnuppy commentedComment #11
fnuppy CreditAttribution: fnuppy as a volunteer commentedComment #12
fnuppy CreditAttribution: fnuppy as a volunteer commentedComment #13
fnuppy CreditAttribution: fnuppy as a volunteer commentedComment #14
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedHere is some coding standard issues:
1.1. There should be space before
(
1.2. Wrong indent (should be 2 spaces, but I see 4)
2.1. Unnecessary spaces before
//
2.2. There is not space after
//
Comment #15
fnuppy CreditAttribution: fnuppy as a volunteer commentedComment #16
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedI've reviewed more in details (hope it's clear):
I think it should be done in another approach. Here you create an entity for each form which stores in db.
If I disable "enabled_default" option, all entities (CaptchaPoint) which were created before won't be removed.
That's a problem. You do not need to create a CaptchaPoint.
can be just `false`
better to use `boolean`
captcha => CAPTCHA
Comment #17
fnuppy CreditAttribution: fnuppy as a volunteer commentedThx, I fixed this problem, I just use fake instance without saving.
Comment #18
ApacheEx CreditAttribution: ApacheEx as a volunteer and at Drupal Ukraine Community commentedMany thanks, looks good for me and do not see any other issues so far.
Comment #20
elachlan CreditAttribution: elachlan commented