Updated: Comment #0
Problem/Motivation
While reviewing #2027183: hook_menu() title callback is ignored on routes
I thought this was a mistake.
Turns out it's in 4 other places.
Since it's fixed in one place in that issue, this issue will fix it in the other places so it's not copied around more.
Proposed resolution
- find all the places: ag "An array of path arguments \(ex: array\('node', '5'\)\)"
- make initial patch (how to: https://drupal.org/contributor-tasks/create-patch)
Remaining tasks
tbd
User interface changes
No.
API changes
No.
Related Issues
Comment | File | Size | Author |
---|---|---|---|
#15 | 2027351-menu-example-docs-15.patch | 3.36 KB | micnap |
#12 | 2027351-menu-example-docs-12.patch | 3.44 KB | longwave |
#10 | 2027351-menu-example-docs-10.patch | 3.44 KB | longwave |
#9 | 2027351-menu-example-docs-9.patch | 3.43 KB | longwave |
#3 | 2027351-2-array-example.patch | 1.67 KB | helenkim |
Comments
Comment #1
YesCT CreditAttribution: YesCT commentedComment #2
YesCT CreditAttribution: YesCT commentedComment #3
helenkim CreditAttribution: helenkim commentedI found the four lists and tidy up the grammar related on the #2027183-6: hook_menu() title callback is ignored on routes.
- * An array of path arguments (ex: array('node', '5'))
+ * An array of path arguments, for example, array('node', '5').
Comment #4
longwaveLooks good.
Comment #5
jhodgdonThanks! Good cleanup. :)
Comment #6
YesCT CreditAttribution: YesCT commented@jhodgdon did you mean to commit it? I didn't see it in the git log.
Comment #7
jhodgdonHaven't done so yet. Will soon. When I do, I'll put an unambiguous message in the issue and change the status. :)
Comment #8
jhodgdonActually... Can we fix the punctuation? The comma before "for example" should actually be a semi-colon. If we're going to clean this up, might as well not introduce a new error. :)
Comment #9
longwaveI figured I should fix up all instances of "for example" in menu.inc at the same time.
Comment #10
longwaveImproved consistency a tiny bit more.
Comment #11
jhodgdonThanks, this all looks good!
Except for one spot -- in the Translate function:
This is missing . at the end, and has an extra ) at the end.
Comment #12
longwaveFixed as per #11.
Comment #13
jhodgdonExcellent! This is ready to commit. Thanks!
Comment #14
jhodgdonThanks again! Committed to 8.x. I think we should backport this to 7.x.
Comment #15
micnap CreditAttribution: micnap commentedA patch for changes in D7.
Comment #16
jhodgdonLooks good, thanks!
Comment #17
jhodgdonThanks again! Committed to 7.x.