Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Lets get rid of those two ugly xml callbacks and turn them to views
Comment | File | Size | Author |
---|---|---|---|
#17 | drupal-aggregator_rss_view-1955760-17.patch | 9.53 KB | lslinnet |
#17 | interdiff-13-to-17.txt | 833 bytes | lslinnet |
#13 | drupal-aggregator_rss_view-1955760-13.patch | 9.49 KB | lslinnet |
#13 | interdiff.txt | 597 bytes | lslinnet |
#10 | drupal-aggregator_rss_view-1955760-6.patch | 9.49 KB | pguillard |
Comments
Comment #1
ParisLiakos CreditAttribution: ParisLiakos commentedpostponed on #1821844: Aggregator views integration
Comment #2
drupalninja99 CreditAttribution: drupalninja99 commentedThis is good since we don't have a clean way (that I am aware of) to cleaning output XML in a page hook anyway.
Comment #3
ParisLiakos CreditAttribution: ParisLiakos commentedintegration is in
Comment #4
ParisLiakos CreditAttribution: ParisLiakos commentedLets keep OPML seperate for now, cause it needs an additional display plugin
Comment #5
dawehnerSo we accept that these settings are dropped?
This seems to be a valid information as well.
Comment #6
ParisLiakos CreditAttribution: ParisLiakos commentedi closed #2004622: aggregator_test output includes drupal page content as duplicate, aggregator/rss is broken atm:) this fixes it
Comment #8
ParisLiakos CreditAttribution: ParisLiakos commented#4: drupal-aggregator_rss_view-1955760-5.patch queued for re-testing.
Comment #9
pguillard CreditAttribution: pguillard commentedComment #10
pguillard CreditAttribution: pguillard commentedApparently something has changed at the same time. This is a new patch that should be ok.
Comment #11
pguillard CreditAttribution: pguillard commentedComment #12
lslinnet CreditAttribution: lslinnet commentedWorking on a reroll of the patch:
Comment #13
lslinnet CreditAttribution: lslinnet commentedThis should be the reroll, including a nice little interdiff
Comment #14
lslinnet CreditAttribution: lslinnet commentedComment #15
Crell CreditAttribution: Crell commentedI checked this out manually and it seems to be fine. The only comment I'd have is that for core views we should probably have meaningful display machine names. I don't know if we've been doing that in other Views conversions, though.
Can someone reroll with a useful machine name for the displays?
Comment #16
lslinnet CreditAttribution: lslinnet commentedWill change the name to something meaning full as suggested.
Comment #17
lslinnet CreditAttribution: lslinnet commentedHave updated the machine names so they now reflect what they are actually a list of (feed_items and feed_items_per_category)
Comment #18
Crell CreditAttribution: Crell commentedYay!
Comment #19
tstoecklerI've seen among others @dawehner specifically request for the auto-generated display names (i.e. feed_1, etc.) to stay. I don't know why that is, and I also find meaningful names, well..., more meaningul!, but I give him the benefit of the doubt that this has a reason.
Comment #20
dawehnerTo be honest this is just personal preference (and the feeling that people overuse this feature), so I will not block that.
Comment #21
YesCT CreditAttribution: YesCT commentedThis issue was RTBC and passing tests on July 1, the beginning of API freeze.
Comment #22
catchCommitted/pushed to 8.x, thanks!
Comment #23.0
(not verified) CreditAttribution: commentedIssue summary update
Comment #24
ParisLiakos CreditAttribution: ParisLiakos commented