Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
It seems to be helpful for various reasons that there are as less tests as possible which are coupled with nodes.
Let's start with the QueryGroupByTest.
Comment | File | Size | Author |
---|---|---|---|
#10 | query_groupby_test-1946208-10.patch | 15.22 KB | dawehner |
#10 | interdiff.txt | 664 bytes | dawehner |
#8 | drupal-1946208-8.patch | 15.22 KB | dawehner |
#3 | drupal-1946208-3.patch | 14.93 KB | dawehner |
#3 | interdiff.txt | 1.5 KB | dawehner |
Comments
Comment #1
dawehnerVarious different places needed work, like the entity_test views integration, as this has been outdated.
Comment #2
damiankloip CreditAttribution: damiankloip commentedThis generally looks great already.
These would prob be better with an assertion message too.
Comment #3
dawehnerYeah why not provide a better message.
Comment #4
dawehner#3: drupal-1946208-3.patch queued for re-testing.
Comment #5
dawehnerComment #6
tim.plunkettIf this still passes, it looks great. Provides just as good coverage and is faster, AND is decoupled from node.module.
Comment #8
dawehnerThere we go.
Comment #9
tim.plunkettI know it used to be camelcased wrong, but let's just fix it here.
Comment #10
dawehnerGood point.
Comment #11
tim.plunkettEven better than the last time I RTBC'd it :)
Comment #12
catchIs this intentional? Looks unrelated.
Comment #13
dawehnerIt was intended as it was helpful to debug this. Views currently has two base test classes, which both has the executeView method:
ViewUnitTestBase()
ViewTestBase (web tests):
Comment #14
alexpottCommitted 1ea2d22 and pushed to 8.x. Thanks!