Follow up for #1953404: Add config schema to field and instance config entities
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in datetime module.
Schema in place
Schema not yet in place
field.datetime.settings
field.datetime.instance_settings
field.datetime.value
field_widget.datetime_default.value
field_widget.datetime_datelist.value
Comment | File | Size | Author |
---|---|---|---|
#10 | dattime_schema-1973534-10.patch | 542 bytes | yched |
#7 | Screen Shot 2013-12-08 at 17.48.51.png | 56.31 KB | vijaycs85 |
#6 | 1973534-diff-3-6.txt | 517 bytes | vijaycs85 |
#6 | 1973534-config-schema-filed-datetime-6.patch | 942 bytes | vijaycs85 |
#3 | 1973534-config-schema-filed-datetime-3.patch | 843 bytes | piyuesh23 |
Comments
Comment #1
vijaycs85Initial patch...
Comment #2
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #3
piyuesh23 CreditAttribution: piyuesh23 at QED42 commentedRemoved the widget from the schema file. Attaching the patch.
Comment #4
piyuesh23 CreditAttribution: piyuesh23 commentedComment #5
aspilicious CreditAttribution: aspilicious commentedDefault value isn't a string. When I inspect it with the config inspector it tries to add an array in the default value. Which doesn't work. So this probably needs a special mapping.
Comment #6
vijaycs85Thanks for the test @aspilicious. Fixed and tested with config_inspector.
Comment #7
vijaycs85Adding config inspector screenshot...
Comment #8
aspilicious CreditAttribution: aspilicious commentedThnx! :)
Comment #9
webchickCommitted and pushed to 8.x. Thanks!
Comment #10
yched CreditAttribution: yched commentedQuick followup: the user_register_form setting is long gone now :-)
Comment #11
yched CreditAttribution: yched commentedNever mind, we'll fix this as part of #1989468: Weird messing with 'default_value_function' in date widgets ?.
Sorry for the noise.