Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
We need to convert node_admin_nodes page callback introduced in #1895160: Convert admin/content to a View, keep a non-views fallback with no bulk operations to a new style controller.
See for instructions: http://drupal.org/node/1800686 & https://drupal.org/node/1953346
Comment | File | Size | Author |
---|---|---|---|
#12 | node-2029569-12.patch | 1.71 KB | tim.plunkett |
#10 | 2029569-convert-node_admin_nodes-9.patch | 12.73 KB | AjitS |
#5 | 2029569-convert-node_admin_nodes-5.patch | 12.73 KB | AjitS |
#4 | 2029569-convert-node_admin_nodes-4.patch | 0 bytes | AjitS |
Comments
Comment #1
pcambraAdding tag
Comment #2
tim.plunkettJust a heads up, you're going to hit the same problems as #1938884: Replace the fallback user listing with a list controller
Comment #3
AjitSAssigning to myself. Will try to roll out a patch soon.
Comment #4
AjitSPatch attached. Keeping this assigned to me. Willing to make changes as per the feedback.
Comment #5
AjitSOops, wrong patch.
Comment #7
tim.plunkettI think the patch was backwards? Also I just realized this is essentially a duplicate of #2021161: Replace the fallback node listing with a list controller...
Comment #8
tim.plunkettExcept that doesn't support paging? Idk what to do here.
Comment #9
pcambraSorry about that @tim.plunkett I searched for node_admin_nodes and didn't find anything.
Agreed, the patch in #5 is kind of weird as it's undoing something is not done yet (?)
Marking this as dupe, @AjitS, please start from #2021161: Replace the fallback node listing with a list controller
Comment #10
AjitSRe-rolling the patch from #5.
Comment #11
AjitSSorry, was working on the re-roll. Didn't realize this was closed. Should have refreshed to page before submitting the patch.
Comment #12
tim.plunkettReopening this for "Phase 1", and leaving the other issue for removing node_admin_nodes() properly.
This will fail until #2027115: Allow views to override existing routing items is committed, will mark "needs review" when that happens.
Comment #13
tim.plunkettComment #14
disasm CreditAttribution: disasm commented#2027115: Allow views to override existing routing items is in. This is simple, don't see any issues. Marking RTBC.
Comment #15
webchickDieeeeee!
Committed and pushed to 8.x. :D
Comment #16
tim.plunkettWoot
Comment #18
xjm