Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pcambra’s picture

Issue tags: +MENU_LOCAL_ACTION

Adding tag

tim.plunkett’s picture

Just a heads up, you're going to hit the same problems as #1938884: Replace the fallback user listing with a list controller

AjitS’s picture

Assigned: Unassigned » AjitS

Assigning to myself. Will try to roll out a patch soon.

AjitS’s picture

Status: Active » Needs review
FileSize
0 bytes

Patch attached. Keeping this assigned to me. Willing to make changes as per the feedback.

AjitS’s picture

Oops, wrong patch.

Status: Needs review » Needs work

The last submitted patch, 2029569-convert-node_admin_nodes-5.patch, failed testing.

tim.plunkett’s picture

I think the patch was backwards? Also I just realized this is essentially a duplicate of #2021161: Replace the fallback node listing with a list controller...

tim.plunkett’s picture

Except that doesn't support paging? Idk what to do here.

pcambra’s picture

Status: Needs work » Closed (duplicate)

Sorry about that @tim.plunkett I searched for node_admin_nodes and didn't find anything.

Agreed, the patch in #5 is kind of weird as it's undoing something is not done yet (?)

Marking this as dupe, @AjitS, please start from #2021161: Replace the fallback node listing with a list controller

AjitS’s picture

Status: Closed (duplicate) » Needs work
FileSize
12.73 KB

Re-rolling the patch from #5.

AjitS’s picture

Status: Needs work » Closed (duplicate)

Sorry, was working on the re-roll. Didn't realize this was closed. Should have refreshed to page before submitting the patch.

tim.plunkett’s picture

Assigned: AjitS » tim.plunkett
Priority: Normal » Major
Status: Closed (duplicate) » Needs work
FileSize
1.71 KB

Reopening this for "Phase 1", and leaving the other issue for removing node_admin_nodes() properly.

This will fail until #2027115: Allow views to override existing routing items is committed, will mark "needs review" when that happens.

tim.plunkett’s picture

Status: Needs work » Needs review
disasm’s picture

Status: Needs review » Reviewed & tested by the community

#2027115: Allow views to override existing routing items is in. This is simple, don't see any issues. Marking RTBC.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Dieeeeee!

Committed and pushed to 8.x. :D

tim.plunkett’s picture

Assigned: tim.plunkett » Unassigned

Woot

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

Component: node.module » node system
Issue summary: View changes