The previous patch testing issue got too big and slow to load.

CommentFileSizeAuthor
#303 forum-page-route-1951268.test.patch85.26 KBlarowlan
#300 block-do-not-test.patch68.22 KBtim.plunkett
#299 block-combined.patch54.96 KBtim.plunkett
#298 block-combined.patch59.18 KBtim.plunkett
#296 block-combined.patch54.96 KBtim.plunkett
#294 plugin-bag.patch108.12 KBtim.plunkett
#293 fapi-titles.patch67.53 KBtim.plunkett
#292 1978958-67.patch13.04 KBPancho
#289 1776796-143b.patch78.17 KBPancho
#287 1776796-143a.patch77.4 KBPancho
#285 1776796-143.patch77.85 KBPancho
#283 1958050_282.patch396.79 KBchx
#281 1958050_280.patch351.36 KBchx
#279 1958050_279.patch338.52 KBchx
#277 1958050_277.patch323.53 KBchx
#275 1958050_275.patch322.72 KBchx
#274 1958050_273.patch201.98 KBchx
#272 1958050_272.patch201.97 KBchx
#268 entity-enabledisable.patch245.83 KBtim.plunkett
#267 1958050_266.patch202.04 KBchx
#266 1958050_266.patch988.29 KBchx
#265 image-2033669-19.patch175.75 KBtim.plunkett
#263 image-objects.patch175.23 KBtim.plunkett
#262 2002138-remove-typeddatainterface-test4.patch123.51 KBdixon_
#260 2002138-remove-typeddatainterface-test3.patch120.83 KBdixon_
#258 2002138-remove-typeddatainterface-test2.patch27.62 KBdixon_
#255 1958050_253.patch216.78 KBchx
#253 2002138-remove-typeddatainterface-test1.patch51.9 KBdixon_
#251 1958050_251.patch217.05 KBchx
#250 drupal-split-load-2024833-61.patch2.39 KBclaudiu.cristea
#248 image-effects.patch27.22 KBtim.plunkett
#246 module_load_include-507396-21.patch60.56 KBPancho
#244 1958050_244.patch185.69 KBchx
#242 1958050_242.patch174.6 KBchx
#240 1958050_240.patch174.61 KBchx
#238 1958050_238.patch162.51 KBchx
#235 1958050_235.patch160.78 KBchx
#232 1958050_232.patch149.84 KBchx
#230 1958050_230.patch144.03 KBchx
#228 no_default_op_reroll.patch46.86 KBamateescu
#226 1958050_226.patch163.53 KBchx
#224 1958050_223.patch160.89 KBchx
#222 1958050_221.patch158.4 KBchx
#219 t1.patch144.34 KBchx
#218 ctcmi.patch147.39 KBamateescu
#215 combined-head-unfailings.patch4.85 KBtim.plunkett
#213 user-page-full.patch99.99 KBtim.plunkett
#213 user-page-no-goto.patch33.68 KBtim.plunkett
#212 fm-13.patch203.25 KBamateescu
#211 fm-12.patch202.55 KBamateescu
#209 fm-11.patch201.6 KBamateescu
#207 fm-10.patch199.55 KBamateescu
#205 fm-9.patch195.44 KBamateescu
#203 fm-8.patch192.45 KBamateescu
#201 fm-7.patch188.07 KBamateescu
#200 fm-6.patch188.53 KBamateescu
#198 fm-5.patch186.25 KBamateescu
#196 fm-4.patch185.57 KBamateescu
#194 fm-3.patch185.56 KBamateescu
#192 fm-2.patch185.11 KBamateescu
#191 fm.patch181.55 KBamateescu
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#190 cache-state-invalidate-1786490-86-partial_3.patch23.29 KBBerdir
#188 cache-state-invalidate-1786490-86-partial.patch23.29 KBBerdir
#188 cache-state-invalidate-1786490-86-partial.patch23.29 KBBerdir
#188 cache-state-invalidate-1786490-86-partial.patch23.29 KBBerdir
#188 cache-state-invalidate-1786490-86-partial.patch23.29 KBBerdir
#186 1958050_185.patch171.95 KBchx
#184 1958050_183.patch171.99 KBchx
#183 1958050_183.patch0 byteschx
#181 entity_display_validation.patch1.19 KBamateescu
#179 1958050_179.patch170.82 KBchx
#177 1958050_177.patch170.92 KBchx
#175 1958050_174.patch149.46 KBchx
#172 1958050_172.patch144.01 KBchx
#170 1958050_169.patch141.57 KBnot_chx
#169 1958050_169.patch0 byteschx
#167 1958050_164.patch141.45 KBchx
#166 1958050_164.patch141.45 KBnot_chx
#165 1958050_164.patch0 byteschx
#163 1958050_160.patch132.47 KBnot_chx
#161 1958050_160.patch0 byteschx
#159 1958050_159.patch0 byteschx
#157 1958050_156.patch131.08 KBchx
#155 1958050_155.patch822.02 KBchx
#153 1958050_153.patch130.63 KBchx
#151 1958050_151.patch117.82 KBchx
#149 action-1846172-FAIL.patch186.8 KBtim.plunkett
#149 action-1846172-PASS.patch187.84 KBtim.plunkett
#147 file_entity_storage.patch4.63 KBslashrsm
#146 1958050_146.patch55.17 KBchx
#144 1958050_144.patch36.91 KBchx
#142 1958050_142.patch33.14 KBchx
#140 1958050_139.patch31.77 KBchx
#139 1958050_139.patch0 byteschx
#138 1958050_137.patch58.23 KBchx
#137 1958050_137.patch0 byteschx
#135 1958050_umh.patch56.15 KBchx
#133 1958050_umh.patch55.78 KBchx
#131 operations.patch180.45 KBtim.plunkett
#129 operations.patch270.13 KBtim.plunkett
#127 erc-2.patch50.35 KBamateescu
#125 erc-1.patch49.86 KBamateescu
#124 operations.patch250.59 KBtim.plunkett
#122 operations.patch248.93 KBtim.plunkett
#120 operations.patch248.72 KBtim.plunkett
#118 operations.patch246.31 KBtim.plunkett
#116 operations.patch196.36 KBtim.plunkett
#114 operations.patch190.3 KBtim.plunkett
#112 operations.patch189.97 KBtim.plunkett
#110 file_reference_field-3.patch57.87 KBamateescu
#109 operations.patch131.07 KBtim.plunkett
#107 file_reference_field-2.patch57.48 KBamateescu
#105 file_reference_field.patch53.08 KBamateescu
#103 operationst.patch124.92 KBtim.plunkett
#101 session.patch66.74 KBParisLiakos
#99 session.patch66.81 KBParisLiakos
#96 session.patch62.28 KBParisLiakos
#95 session.patch62.25 KBParisLiakos
#94 session.patch967.95 KBParisLiakos
#92 session.patch61.43 KBParisLiakos
#90 session.patch60.99 KBParisLiakos
#89 drupal-1953800-test3.patch26.88 KBamateescu
#88 drupal-1953800-test2.patch26.81 KBamateescu
#87 drupal-1953800-test1.patch26.81 KBamateescu
#87 drupal-1953800-test2.patch54.47 KBamateescu
#85 1958050_84.patch338.5 KBchx
#84 1958050_84.patch0 byteschx
#82 1958050_81.patch325.35 KBchx
#78 1958050_74.patch325.31 KBchx
#77 1958050_73.patch8.99 KBchx
#75 drupal-redirectResponse-1668866_.patch73.74 KBParisLiakos
#75 drupal-redirectResponse-1668866__.patch74.07 KBParisLiakos
#73 drupal-redirectResponse-1668866.patch74.91 KBParisLiakos
#71 redirectResponse.patch74.7 KBParisLiakos
#70 Selection_138.png10.93 KBchx
#68 1958050_68.patch301.17 KBchx
#66 uccuneki.patch285.18 KBszantog
#64 content.patch29.99 KBtim.plunkett
#63 t_wrapper_.patch62.67 KBParisLiakos
#61 t_wrapper.patch62.67 KBParisLiakos
#60 1958050_60.patch266.74 KBchx
#58 t_wrapper.patch61.92 KBParisLiakos
#56 static-cache.patch15.85 KBtim.plunkett
#54 1958050_54.patch260.27 KBchx
#52 t_service_wrapper.patch51.92 KBParisLiakos
#51 edit-attachments.patch2.48 KBtim.plunkett
#49 1958050_49.patch236.53 KBchx
#48 1958050_48.patch294.88 KBchx
#46 1958050_46.patch236.2 KBchx
#45 1958050_45.patch235.65 KBchx
#43 cache-state-invalidate-1786490-80.patch21.63 KBBerdir
#43 cache-state-invalidate-1786490-80.patch21.63 KBBerdir
#43 cache-state-invalidate-1786490-80.patch21.63 KBBerdir
#43 cache-state-invalidate-1786490-80.patch21.63 KBBerdir
#43 cache-state-invalidate-1786490-80.patch21.63 KBBerdir
#42 drupal_info-type-key-1292284-22.patch88.5 KBParisLiakos
#40 t_as_a_wrapper.patch51.41 KBParisLiakos
#38 t_as_a_wrapper.patch51.41 KBParisLiakos
#36 this_wont_pass.patch160.78 KBchx
#34 this_wont_pass.patch148.61 KBchx
#32 this_wont_pass.patch143.81 KBchx
#31 this_wont_pass.patch0 byteschx
#29 field_ui.patch75.27 KBtim.plunkett
#27 field_ui.patch61.52 KBtim.plunkett
#24 why_iz_here.patch398 bytesParisLiakos
#22 viewmode.patch20.68 KBtim.plunkett
#20 wondering.patch677 bytesxjm
#18 erc-3.patch36.2 KBamateescu
#16 erc-2.patch32.98 KBamateescu
#14 erc-1.patch28.32 KBamateescu
#12 vdc-destroy.patch3.74 KBtim.plunkett
#10 menu-fail.patch284.86 KBtim.plunkett
#9 term_item-2.patch24.27 KBamateescu
#7 term_item.patch23.13 KBamateescu
#5 block-craziness.patch90.02 KBtim.plunkett
#2 block-craziness.patch88.12 KBtim.plunkett
#2 interdiff.txt3.75 KBtim.plunkett
#1 block-craziness.patch87.09 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

Status: Active » Needs review
FileSize
87.09 KB
tim.plunkett’s picture

FileSize
3.75 KB
88.12 KB
tim.plunkett’s picture

FileSize
90.02 KB
amateescu’s picture

FileSize
23.13 KB
amateescu’s picture

FileSize
24.27 KB
tim.plunkett’s picture

FileSize
284.86 KB
tim.plunkett’s picture

FileSize
3.74 KB
amateescu’s picture

FileSize
28.32 KB
amateescu’s picture

FileSize
32.98 KB
amateescu’s picture

FileSize
36.2 KB
xjm’s picture

FileSize
677 bytes
tim.plunkett’s picture

FileSize
20.68 KB
ParisLiakos’s picture

FileSize
398 bytes
tim.plunkett’s picture

FileSize
61.52 KB
tim.plunkett’s picture

FileSize
75.27 KB
chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
143.81 KB
chx’s picture

FileSize
148.61 KB

That's not what I had in mind.

chx’s picture

FileSize
160.78 KB
ParisLiakos’s picture

FileSize
51.41 KB
ParisLiakos’s picture

FileSize
51.41 KB
ParisLiakos’s picture

Berdir’s picture

chx’s picture

FileSize
235.65 KB
chx’s picture

FileSize
236.2 KB

Forgot to add a file.

chx’s picture

FileSize
294.88 KB
chx’s picture

FileSize
236.53 KB
tim.plunkett’s picture

FileSize
2.48 KB
ParisLiakos’s picture

FileSize
51.92 KB

lets see how badly this fails

chx’s picture

FileSize
260.27 KB
tim.plunkett’s picture

FileSize
15.85 KB
ParisLiakos’s picture

Status: Needs review » Needs work
FileSize
61.92 KB
chx’s picture

Status: Needs work » Needs review
FileSize
266.74 KB
ParisLiakos’s picture

FileSize
62.67 KB

previous patch stuck..needs cancelling..here is a new one

ParisLiakos’s picture

FileSize
62.67 KB
tim.plunkett’s picture

FileSize
29.99 KB
szantog’s picture

FileSize
285.18 KB
chx’s picture

FileSize
301.17 KB
chx’s picture

Status: Needs review » Needs work
FileSize
10.93 KB
ParisLiakos’s picture

Status: Needs work » Needs review
FileSize
74.7 KB
ParisLiakos’s picture

ParisLiakos’s picture

chx’s picture

FileSize
8.99 KB
chx’s picture

FileSize
325.31 KB
chx’s picture

FileSize
325.35 KB
chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
338.5 KB
amateescu’s picture

amateescu’s picture

FileSize
26.81 KB
amateescu’s picture

FileSize
26.88 KB
ParisLiakos’s picture

FileSize
60.99 KB
ParisLiakos’s picture

FileSize
61.43 KB
ParisLiakos’s picture

FileSize
967.95 KB

and with updated vendors...

ParisLiakos’s picture

FileSize
62.25 KB

nope..

ParisLiakos’s picture

FileSize
62.28 KB
cosmicdreams’s picture

+++ b/core/lib/Drupal/Core/EventSubscriber/SessionListener.phpundefined
@@ -0,0 +1,98 @@
+      // @todo Restore this once all page callbacks are converted to new routing
+      // @see drupal_session_initialize().

Restore what? I don't see anything being commented out here.

+++ b/core/lib/Drupal/Core/Session/Session.phpundefined
@@ -0,0 +1,204 @@
+    $cookies = array();

All in all I really like how this code has evolved. Great work.
$cookies should be initialized with the object not scoped as a local variable.

+++ b/core/lib/Drupal/Core/Session/Session.phpundefined
@@ -0,0 +1,204 @@
+   * dangerous operations, such as manipulating the global $user object.

Do we intend to have a "global" $user object by the end of D8?

+++ b/core/lib/Drupal/Core/Session/Storage/Proxy/CookieProxy.phpundefined
@@ -0,0 +1,399 @@
+   * @todo Fix one http://drupal.org/node/1825332 is in.

s/one/once

+++ b/core/lib/Drupal/Core/Session/Storage/Proxy/CookieProxy.phpundefined
@@ -0,0 +1,399 @@
+   * @todo Fill me.

Do @todo's like this one mean that you're asking for documentation of methods like this.

ParisLiakos’s picture

FileSize
66.81 KB
ParisLiakos’s picture

FileSize
66.74 KB
tim.plunkett’s picture

FileSize
124.92 KB
amateescu’s picture

FileSize
53.08 KB
amateescu’s picture

FileSize
57.48 KB
tim.plunkett’s picture

FileSize
131.07 KB
amateescu’s picture

FileSize
57.87 KB
tim.plunkett’s picture

FileSize
189.97 KB
tim.plunkett’s picture

FileSize
190.3 KB
tim.plunkett’s picture

FileSize
196.36 KB
tim.plunkett’s picture

FileSize
246.31 KB
tim.plunkett’s picture

FileSize
248.72 KB
tim.plunkett’s picture

FileSize
248.93 KB
tim.plunkett’s picture

FileSize
250.59 KB
amateescu’s picture

FileSize
49.86 KB
amateescu’s picture

FileSize
50.35 KB
tim.plunkett’s picture

FileSize
270.13 KB
tim.plunkett’s picture

FileSize
180.45 KB
chx’s picture

FileSize
55.78 KB
chx’s picture

FileSize
56.15 KB
chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
58.23 KB
chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
31.77 KB
chx’s picture

FileSize
33.14 KB
chx’s picture

FileSize
36.91 KB
chx’s picture

FileSize
55.17 KB
slashrsm’s picture

FileSize
4.63 KB
tim.plunkett’s picture

chx’s picture

FileSize
117.82 KB
chx’s picture

FileSize
130.63 KB
chx’s picture

FileSize
822.02 KB
chx’s picture

FileSize
131.08 KB
chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
0 bytes
not_chx’s picture

FileSize
132.47 KB
chx’s picture

FileSize
0 bytes
not_chx’s picture

FileSize
141.45 KB
chx’s picture

FileSize
141.45 KB

Status: Needs review » Needs work

The last submitted patch, 1958050_164.patch, failed testing.

chx’s picture

Status: Needs work » Needs review
FileSize
0 bytes
not_chx’s picture

FileSize
141.57 KB
chx’s picture

Status: Needs review » Needs work
FileSize
144.01 KB
chx’s picture

Status: Needs work » Needs review
FileSize
149.46 KB
chx’s picture

FileSize
170.92 KB
chx’s picture

FileSize
170.82 KB

aaaargh.

amateescu’s picture

chx’s picture

FileSize
0 bytes
chx’s picture

FileSize
171.99 KB
chx’s picture

FileSize
171.95 KB
Berdir’s picture

Berdir’s picture

#186: 1958050_185.patch queued for re-testing.

amateescu’s picture

FileSize
181.55 KB
amateescu’s picture

FileSize
185.11 KB
amateescu’s picture

FileSize
185.56 KB
amateescu’s picture

FileSize
185.57 KB
amateescu’s picture

FileSize
186.25 KB
amateescu’s picture

FileSize
188.53 KB
amateescu’s picture

FileSize
188.07 KB
amateescu’s picture

FileSize
192.45 KB
amateescu’s picture

FileSize
195.44 KB
amateescu’s picture

FileSize
199.55 KB
amateescu’s picture

FileSize
201.6 KB
amateescu’s picture

FileSize
202.55 KB
amateescu’s picture

FileSize
203.25 KB
tim.plunkett’s picture

tim.plunkett’s picture

Status: Needs review » Needs work
FileSize
4.85 KB
amateescu’s picture

Status: Needs work » Needs review
FileSize
147.39 KB
chx’s picture

FileSize
144.34 KB
chx’s picture

FileSize
158.4 KB
chx’s picture

FileSize
160.89 KB
chx’s picture

FileSize
163.53 KB
amateescu’s picture

FileSize
46.86 KB
chx’s picture

FileSize
144.03 KB
chx’s picture

Status: Needs review » Needs work
FileSize
149.84 KB
chx’s picture

FileSize
160.78 KB
chx’s picture

Status: Needs work » Needs review
FileSize
162.51 KB
chx’s picture

FileSize
174.61 KB
chx’s picture

FileSize
174.6 KB
chx’s picture

FileSize
185.69 KB
Pancho’s picture

tim.plunkett’s picture

FileSize
27.22 KB
claudiu.cristea’s picture

chx’s picture

FileSize
217.05 KB
dixon_’s picture

chx’s picture

Status: Needs review » Needs work
FileSize
216.78 KB
dixon_’s picture

Status: Needs work » Needs review
FileSize
27.62 KB
dixon_’s picture

dixon_’s picture

tim.plunkett’s picture

FileSize
175.23 KB
tim.plunkett’s picture

FileSize
175.75 KB
chx’s picture

FileSize
988.29 KB
chx’s picture

FileSize
202.04 KB
tim.plunkett’s picture

FileSize
245.83 KB
chx’s picture

FileSize
201.97 KB
chx’s picture

FileSize
201.98 KB
chx’s picture

FileSize
322.72 KB
chx’s picture

FileSize
323.53 KB
chx’s picture

FileSize
338.52 KB
chx’s picture

FileSize
351.36 KB
chx’s picture

FileSize
396.79 KB
Pancho’s picture

FileSize
77.85 KB
Pancho’s picture

FileSize
77.4 KB
Pancho’s picture

FileSize
78.17 KB
Pancho’s picture

Assigned: tim.plunkett » Unassigned
FileSize
13.04 KB
tim.plunkett’s picture

FileSize
67.53 KB
tim.plunkett’s picture

FileSize
108.12 KB
tim.plunkett’s picture

FileSize
54.96 KB
tim.plunkett’s picture

FileSize
59.18 KB
tim.plunkett’s picture

FileSize
54.96 KB
tim.plunkett’s picture

FileSize
68.22 KB

Status: Needs review » Needs work

The last submitted patch, block-combined.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Closed (won't fix)

Someone make a new one.

larowlan’s picture

Status: Closed (won't fix) » Needs review
FileSize
85.26 KB

couldn't find a new one

larowlan’s picture

Status: Needs review » Closed (fixed)
jthorson’s picture

Issue summary: View changes
jthorson’s picture

jthorson’s picture