Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
The previous patch testing issue got too big and slow to load.
Comment | File | Size | Author |
---|---|---|---|
#303 | forum-page-route-1951268.test.patch | 85.26 KB | larowlan |
#268 | entity-enabledisable.patch | 245.83 KB | tim.plunkett |
#267 | 1958050_266.patch | 202.04 KB | chx |
#266 | 1958050_266.patch | 988.29 KB | chx |
#265 | image-2033669-19.patch | 175.75 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettComment #2
tim.plunkettComment #5
tim.plunkettComment #7
amateescu CreditAttribution: amateescu commentedComment #9
amateescu CreditAttribution: amateescu commentedComment #10
tim.plunkettComment #12
tim.plunkettComment #14
amateescu CreditAttribution: amateescu commentedComment #16
amateescu CreditAttribution: amateescu commentedComment #18
amateescu CreditAttribution: amateescu commentedComment #20
xjmComment #22
tim.plunkettComment #24
ParisLiakos CreditAttribution: ParisLiakos commentedComment #27
tim.plunkettComment #29
tim.plunkettComment #31
chx CreditAttribution: chx commentedComment #32
chx CreditAttribution: chx commentedComment #34
chx CreditAttribution: chx commentedThat's not what I had in mind.
Comment #36
chx CreditAttribution: chx commentedComment #38
ParisLiakos CreditAttribution: ParisLiakos commentedComment #40
ParisLiakos CreditAttribution: ParisLiakos commentedComment #42
ParisLiakos CreditAttribution: ParisLiakos commentedComment #43
BerdirTrying to find out why this fails randomly...
Comment #45
chx CreditAttribution: chx commentedComment #46
chx CreditAttribution: chx commentedForgot to add a file.
Comment #48
chx CreditAttribution: chx commentedComment #49
chx CreditAttribution: chx commentedComment #51
tim.plunkettComment #52
ParisLiakos CreditAttribution: ParisLiakos commentedlets see how badly this fails
Comment #54
chx CreditAttribution: chx commentedComment #56
tim.plunkettComment #58
ParisLiakos CreditAttribution: ParisLiakos commentedComment #60
chx CreditAttribution: chx commentedComment #61
ParisLiakos CreditAttribution: ParisLiakos commentedprevious patch stuck..needs cancelling..here is a new one
Comment #63
ParisLiakos CreditAttribution: ParisLiakos commentedComment #64
tim.plunkettComment #66
szantog CreditAttribution: szantog commentedComment #68
chx CreditAttribution: chx commentedComment #70
chx CreditAttribution: chx commentedComment #71
ParisLiakos CreditAttribution: ParisLiakos commentedComment #73
ParisLiakos CreditAttribution: ParisLiakos commentedComment #75
ParisLiakos CreditAttribution: ParisLiakos commentedComment #77
chx CreditAttribution: chx commentedComment #78
chx CreditAttribution: chx commentedComment #82
chx CreditAttribution: chx commentedComment #84
chx CreditAttribution: chx commentedComment #85
chx CreditAttribution: chx commentedComment #87
amateescu CreditAttribution: amateescu commentedComment #88
amateescu CreditAttribution: amateescu commentedComment #89
amateescu CreditAttribution: amateescu commentedComment #90
ParisLiakos CreditAttribution: ParisLiakos commentedComment #92
ParisLiakos CreditAttribution: ParisLiakos commentedComment #94
ParisLiakos CreditAttribution: ParisLiakos commentedand with updated vendors...
Comment #95
ParisLiakos CreditAttribution: ParisLiakos commentednope..
Comment #96
ParisLiakos CreditAttribution: ParisLiakos commentedComment #97
cosmicdreams CreditAttribution: cosmicdreams commentedRestore what? I don't see anything being commented out here.
All in all I really like how this code has evolved. Great work.
$cookies should be initialized with the object not scoped as a local variable.
Do we intend to have a "global" $user object by the end of D8?
s/one/once
Do @todo's like this one mean that you're asking for documentation of methods like this.
Comment #99
ParisLiakos CreditAttribution: ParisLiakos commentedComment #101
ParisLiakos CreditAttribution: ParisLiakos commentedComment #103
tim.plunkettComment #105
amateescu CreditAttribution: amateescu commentedComment #107
amateescu CreditAttribution: amateescu commentedComment #109
tim.plunkettComment #110
amateescu CreditAttribution: amateescu commentedComment #112
tim.plunkettComment #114
tim.plunkettComment #116
tim.plunkettComment #118
tim.plunkettComment #120
tim.plunkettComment #122
tim.plunkettComment #124
tim.plunkettComment #125
amateescu CreditAttribution: amateescu commentedComment #127
amateescu CreditAttribution: amateescu commentedComment #129
tim.plunkettComment #131
tim.plunkettComment #133
chx CreditAttribution: chx commentedComment #135
chx CreditAttribution: chx commentedComment #137
chx CreditAttribution: chx commentedComment #138
chx CreditAttribution: chx commentedComment #139
chx CreditAttribution: chx commentedComment #140
chx CreditAttribution: chx commentedComment #142
chx CreditAttribution: chx commentedComment #144
chx CreditAttribution: chx commentedComment #146
chx CreditAttribution: chx commentedComment #147
slashrsm CreditAttribution: slashrsm commentedComment #149
tim.plunkettComment #151
chx CreditAttribution: chx commentedComment #153
chx CreditAttribution: chx commentedComment #155
chx CreditAttribution: chx commentedComment #157
chx CreditAttribution: chx commentedComment #159
chx CreditAttribution: chx commentedComment #161
chx CreditAttribution: chx commentedComment #163
not_chx CreditAttribution: not_chx commentedComment #165
chx CreditAttribution: chx commentedComment #166
not_chx CreditAttribution: not_chx commentedComment #167
chx CreditAttribution: chx commentedComment #169
chx CreditAttribution: chx commentedComment #170
not_chx CreditAttribution: not_chx commentedComment #172
chx CreditAttribution: chx commentedComment #175
chx CreditAttribution: chx commentedComment #177
chx CreditAttribution: chx commentedComment #179
chx CreditAttribution: chx commentedaaaargh.
Comment #181
amateescu CreditAttribution: amateescu commentedComment #183
chx CreditAttribution: chx commentedComment #184
chx CreditAttribution: chx commentedComment #186
chx CreditAttribution: chx commentedComment #188
BerdirTestbot isn't nice to me.
Comment #189
Berdir#186: 1958050_185.patch queued for re-testing.
Comment #190
BerdirTrying some more, not sure if only the patch with all tests is randomly failing.
Comment #191
amateescu CreditAttribution: amateescu commentedComment #192
amateescu CreditAttribution: amateescu commentedComment #194
amateescu CreditAttribution: amateescu commentedComment #196
amateescu CreditAttribution: amateescu commentedComment #198
amateescu CreditAttribution: amateescu commentedComment #200
amateescu CreditAttribution: amateescu commentedComment #201
amateescu CreditAttribution: amateescu commentedComment #203
amateescu CreditAttribution: amateescu commentedComment #205
amateescu CreditAttribution: amateescu commentedComment #207
amateescu CreditAttribution: amateescu commentedComment #209
amateescu CreditAttribution: amateescu commentedComment #211
amateescu CreditAttribution: amateescu commentedComment #212
amateescu CreditAttribution: amateescu commentedComment #213
tim.plunkettComment #215
tim.plunkettComment #218
amateescu CreditAttribution: amateescu commentedComment #219
chx CreditAttribution: chx commentedComment #222
chx CreditAttribution: chx commentedComment #224
chx CreditAttribution: chx commentedComment #226
chx CreditAttribution: chx commentedComment #228
amateescu CreditAttribution: amateescu commentedComment #230
chx CreditAttribution: chx commentedComment #232
chx CreditAttribution: chx commentedComment #235
chx CreditAttribution: chx commentedComment #238
chx CreditAttribution: chx commentedComment #240
chx CreditAttribution: chx commentedComment #242
chx CreditAttribution: chx commentedComment #244
chx CreditAttribution: chx commentedComment #246
PanchoComment #248
tim.plunkettComment #250
claudiu.cristeaComment #251
chx CreditAttribution: chx commentedComment #253
dixon_Comment #255
chx CreditAttribution: chx commentedComment #258
dixon_Comment #260
dixon_Comment #262
dixon_Comment #263
tim.plunkettComment #265
tim.plunkettComment #266
chx CreditAttribution: chx commentedComment #267
chx CreditAttribution: chx commentedComment #268
tim.plunkettComment #272
chx CreditAttribution: chx commentedComment #274
chx CreditAttribution: chx commentedComment #275
chx CreditAttribution: chx commentedComment #277
chx CreditAttribution: chx commentedComment #279
chx CreditAttribution: chx commentedComment #281
chx CreditAttribution: chx commentedComment #283
chx CreditAttribution: chx commentedComment #285
PanchoComment #287
PanchoComment #289
PanchoComment #292
PanchoComment #293
tim.plunkettComment #294
tim.plunkettComment #296
tim.plunkettComment #298
tim.plunkettComment #299
tim.plunkettComment #300
tim.plunkettComment #302
tim.plunkettSomeone make a new one.
Comment #303
larowlancouldn't find a new one
Comment #304
larowlanComment #305
jthorson CreditAttribution: jthorson commentedComment #306
jthorson CreditAttribution: jthorson commentedComment #307
jthorson CreditAttribution: jthorson commented