New installer sidebar not properly RTL [#2033137]

Comment	File	Size	Author
#1	drupal-installer_rtl-2033137-1.patch	403 bytes	yannickoo

#1	Screen Shot 2013-07-02 at 17.56.25.png	855.82 KB	yannickoo
	_لاحة_تركيب___Drupal.png	96.81 KB	Gábor Hojtsy

Comment #1

yannickoo

Berlin

CreditAttribution: yannickoo commented 2 July 2013 at 15:57

Status:

Active

» Needs review

File	Size
Screen Shot 2013-07-02 at 17.56.25.png	855.82 KB
drupal-installer_rtl-2033137-1.patch	403 bytes

Just added a float: right; for the first sidebar.
Screen Shot 2013-07-02 at 17.56.25.png

Log in or register to post comments

Comment #2

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 2 July 2013 at 16:02

Status:

Needs review

» Reviewed & tested by the community

Looks good. I looked at the patch committed in #1337554: Develop and use separate branding for the installer and it did not have this in the last incarnation, so it was not something we lots in the RTL CSS integration, it was just simply a mistake.

Log in or register to post comments

Comment #3

yannickoo

Berlin

CreditAttribution: yannickoo commented 2 July 2013 at 16:07

I was confused because the patch included the installer-page-rtl.css file and when I cloned the Git repository it wasn't there. Gábor, do you know why the Seven's CSS files are not in a CSS directory? I know that this would be an extra issue but just asking :)