Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Choose language(done)
should be Choose language (done)
for example.
Comment | File | Size | Author |
---|---|---|---|
#6 | space-inside-span-2022233-6.patch | 603 bytes | StephaneQ |
#1 | fix-missing-spaces-2022233-1.patch | 603 bytes | StephaneQ |
Comments
Comment #1
StephaneQHere is my first patch, hope I did it correctly
Comment #2
thedavidmeister CreditAttribution: thedavidmeister commentedhmm, maybe the space should go inside the "visually-hidden" span rather than before it, what do you think?
Comment #3
StephaneQInside or outside the span, browsers render it the same way, so I thought it was cleaner to put it outside.
Tell me if I'm wrong, I'll resend the patch.
Comment #4
webflo CreditAttribution: webflo commentedI think this is okay.
Comment #5
thedavidmeister CreditAttribution: thedavidmeister commented#3 it renders differently if the span is hidden with CSS
Comment #6
StephaneQOk, so let's put it inside the span
Comment #7
thedavidmeister CreditAttribution: thedavidmeister commented#6 looks good to me.
Comment #8
alexpottCommitted 972bdf1 and pushed to 8.x. Thanks!