Choose language(done) should be Choose language (done) for example.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

StephaneQ’s picture

Status: Active » Needs review
FileSize
603 bytes

Here is my first patch, hope I did it correctly

thedavidmeister’s picture

hmm, maybe the space should go inside the "visually-hidden" span rather than before it, what do you think?

StephaneQ’s picture

Inside or outside the span, browsers render it the same way, so I thought it was cleaner to put it outside.

Tell me if I'm wrong, I'll resend the patch.

webflo’s picture

Status: Needs review » Reviewed & tested by the community

I think this is okay.

thedavidmeister’s picture

#3 it renders differently if the span is hidden with CSS

StephaneQ’s picture

Ok, so let's put it inside the span

thedavidmeister’s picture

#6 looks good to me.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 972bdf1 and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.