Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I created a new article after fresh Installation.
I tried to edit this first article (click on tab Edit), but some parts of form in overlay are not working right
(screenshot attached).
Everything is right if I go to node edit form through CONTENT/OPERATION EDIT
I think it is a browser compability problem , because in Firefox 21 it works ok.
Comment | File | Size | Author |
---|---|---|---|
#24 | core-js-domready-IE-2004098-24.patch | 1.69 KB | nod_ |
#16 | drupal-2004098-16.patch | 1.64 KB | elachlan |
#15 | drupal-2004098-15.patch | 1.64 KB | elachlan |
#13 | Capture.PNG | 54.8 KB | elachlan |
#3 | core-js-domready-IE-2004098-2.patch | 1.6 KB | nod_ |
Comments
Comment #1
nod_What is your javascript console saying?
Comment #2
Micha1111 CreditAttribution: Micha1111 commentedSorry , I don't know, how to do that.
Comment #3
nod_ok, it's because of domready. See #1974580-29: Introduce domReady to remove jQuery dependency from drupal.js and clean it up.
The patch updates domready with this pull request https://github.com/ded/domready/pull/17.
Comment #4
nod_Also it's a JS bug so tagging.
Comment #5
aspilicious CreditAttribution: aspilicious commentedWorking fine with the patch. I prefer the library to get updated first, but oh well...
Comment #6
droplet CreditAttribution: droplet commentedHappy to see it :)
Comment #7
nod_let's update the lib first and turn that into an update library X issue.
Comment #8
droplet CreditAttribution: droplet commentedAuthor said the same word a year ago [ https://github.com/ded/domready/issues/14 ]. Drupalers need to submit a new patch to GITHUB or patch it directly.
Comment #9
catchDon't understand why this is postponed.
Comment #10
elachlan CreditAttribution: elachlan commentedPatch from #3 does not fix the issue.
Furthermore, I had to manually navigate to "/#overlay=node/add/article".
The links without the overlay work. But only if you click the anchor tag, not if you click on the area around it.
Comment #11
elachlan CreditAttribution: elachlan commentedI tested a few other overlay forms. All the forms which use this functionality are broken. So you cannot close an overlay form.
Comment #12
droplet CreditAttribution: droplet commented@see: https://drupal.org/node/2003854#comment-7565911
Comment #13
elachlan CreditAttribution: elachlan commentedConsole does not report that error.
I only get the follow error for the front page.
The save and publish button also looks broken.
Also how is "ready.min.js" added the drupal? Shouldn't we add it to a library somewhere?
Comment #14
elachlan CreditAttribution: elachlan commentedThe above patch applies the js file to
core/misc/domready/ready.min.js
If I look at the html is actually is pointing to
core/assets/vendor/domready/ready.min.js?v=master
Comment #15
elachlan CreditAttribution: elachlan commentedRe-rolled the patch from #3 to the right folder. Looks like it works.
Comment #16
elachlan CreditAttribution: elachlan commentedChanged the actual source instead of using the code supplied by #3.
It looks like the maintainer isn't to active on https://github.com/ded/domready
Comment #17
elachlan CreditAttribution: elachlan commentedAdding Tag. Unit testing will not work with this change. Needs to be tested against multiple browsers.
Comment #18
nod_Maintainer is active, the pull requests just don't merge properly.
For testing only IE is needed, it doesn't change anything for the other browsers.
Comment #19
elachlan CreditAttribution: elachlan commentedI have created a pull request with the changes re-rolled. There are some subtle changes.
https://github.com/ded/domready/pull/21
Comment #20
elachlan CreditAttribution: elachlan commentedInformation on readystate for further reading. It has being discontinued in IE 11 in favour of onload().
http://msdn.microsoft.com/en-us/library/ie/ms534359(v=vs.85).aspx
Comment #21
nod_the page you linked to talks about the script element. not for a page. it does not impact this script functionality.
Comment #22
nod_thanks for making the pull request elachlan :) now we just need to wait for the commit.
Comment #23
catchYep. Postponing on upstream.
Comment #24
nod_Merged. Boom :)
https://github.com/ded/domready/pull/21#ref-commit-baafbee
Comment #25
elachlan CreditAttribution: elachlan commentedLooks good to me and the patch is green! Good work everyone! :)
Comment #26
catchComment #27
catchCommitted/pushed to 8.x, thanks!