Upgrade path: Meta tags quick

Agreed that this would be useful!

Subscribe please

@Wellsy Note that there is now a follow button in the top right. No need to comment to subscribe!

Thanks @rickvug. Is that new?

Edit: Just seen the homepage - yes it is new. Nice

@Wellsy Yes, as of yesterday I believe. See http://drupal.org/node/1306444 for the announcement.

Here is code snippet for copy node metatags from metatags_quick to metatag module:

  $result=db_query("SELECT node.nid, field_data_meta_description.meta_description_metatags_quick, field_data_meta_keywords.meta_keywords_metatags_quick FROM {node} 
  LEFT JOIN {field_data_meta_description} ON (field_data_meta_description.entity_type='node' AND field_data_meta_description.entity_id=node.nid)
  LEFT JOIN {field_data_meta_keywords} ON (field_data_meta_keywords.entity_type='node' AND field_data_meta_keywords.entity_id=node.nid)
  ");
  foreach($result as $row) {
    if(!empty($row->meta_description_metatags_quick)) $metatags[$row->nid]['description']['value']=$row->meta_description_metatags_quick;
    if(!empty($row->meta_keywords_metatags_quick)) $metatags[$row->nid]['keywords']['value']=$row->meta_keywords_metatags_quick;
  }
  
  foreach($metatags as $id=>$item) {
    db_merge('metatag')
      ->key(array(
        'entity_type' => 'node',
        'entity_id' => $id,
      ))
      ->fields(array(
        'data' => serialize($item),
      ))
      ->execute();
  }

Here's a drush command metatag-import-mtq that is essentially a more complete version of the code snippet provided in #7. In addition to the fields left out there, it handles language as expected and clears the metatag cache for all nodes.

Don't know what the maintainers are thinking strategically for these "upgrade paths" (separate module, providing a GUI, etc.), but this drush command could easily be moved somewhere else and just invoked from drush in a different way.

Adding a check for the existence of the Meta Tags quick field tables. Also adding some feedback about how much data is being imported.

Also realized that this doesn't take into account Meta Tags Quick path-based meta tags, which I don't use.

Here's a patch that also takes care of Meta Tags Quick paths by generating a series of contexts. It checks that Meta Tags: Context is enabled before attempting.

Also added support for the Meta Tags Quick canonical field that the previous patches missed.

Attempted to bring over "revisit after" data, but I don't think this module supports it, currently.

Noticed there was a problem migrating robots fields; Meta Tags expects them in the form array('noindex' => 'noindex'), while the previous patch was feeding it array('noindex').

This patch takes care of that. Otherwise, the same.

Lets retest it.

#15: metatag-import_from_meta_tags_quick-1282806-15.patch queued for re-testing.

Related: #1498764: Add new meta tag: Revisit-After (D7)

Needs work:

• Metatag now needs supports the 'REVISIT-AFTER' tag.
• The page title tag needs to be supported.
• Does the Metatag module itself need to be listed as a dependency for the task?
• It must support any entity rather that just nodes.

@HyperGlide: I'm not saying to expand beyond what Metatags_Quick can handle, I'm saying to expand it to cover all of the functionality that Metatags_Quick already can handle. The module uses entity and field hooks, therefore it is not strictly tied to nodes, but this upgrade script can only handle nodes.

Further:

• The most recent commit, from May, adds support for the page title via the "Set page title" field formatter.
• The REVISIT-AFTER meta tag can be created by Metatags_Quick, is supported by Metatag, and there's a commented-out line in the script for it, so it should be supported with this upgrade script.

I think this is a good first pass, but it really would be best to rewrite it to actually query the field API configuration rather than only work with a few hardcoded field names.

Basically it may be best to start from the list of meta tags supported by Metatag and see if there's an easy way of migrating any fields matching those tags. It'll be more effort, but IMHO ultimately will provide a better ex

Sadly this doesn't work now that Metatag supports revision (since metatag 7.x-1.0-beta8). The revision_id column on the metatag table for the imported rows are all set to '0' (the default) as the import script didn't supply this data.

I'll see if I can quickly add this.

Thanks,
Victoria

I've updated the patch from #15 to include the vid / revision_id data.

Thanks,
Victoria

Also for consideration, an update script to migrate the title, description and keywords fields that uses the Fields API to identify which fields to migrate.

While my update script works for a limited use case, the real goal will be available both a drush script and through the website admin.

Rerolled.

Patch #35 won't work as metatag_update_7037() is already in use. Anyway it cant work with an metatag_update_N hook, as it does not update metatag module and I guess it won't work on a fresh installation.

I thought of it as an update for metatags_quick module and changed the function name to metatags_quick_update_7400(). I guess there won't be a version 7.x-4.x of Meta tags quick. This worked for me for a small site. A more solid solution would be create a new module for this purpose with the functionality in hook_install. This module can also take care of the deletion of the metatags quick fields, see also #1341252: Document how to uninstall Meta tags quick.

Beside the renaming of the update hook I had some minor modifications. I added a diff for the old patch from #35 to the new one. Its a normal diff (so a bit harder to read), as interdiff would have marked everything as changed:

• More explanation in the function description to print warning on drush updb
• Fallback to entity language if no field language is set
• Modify delete query to use $quick['language'] instead of $language (see 2.)
• Watchdog messages.

Wouldn't it make more sense to include this functionality with the "metatag_importer" submodule?

Also I needed to change
metatag_metatags_save($entity_type, $entity_id, $revision_id, $data, $langcode);
to
metatag_metatags_save($entity_type, $entity_id, $revision_id, $data, $bundle);
to match the function signature for metatag_metatags_save(); otherwise no meta tags were saved on my multilingual site.

@klokie: Excellent point! Yeah, this does need to be moved to scripts for Metatag Installer.

Here's a patch based on #37, taking into account the feedback above.

I haven't written an admin form for it, but it seems to be working OK from the drush command

Tried the latest patch and it did migrate my data. However, it really gave me no indication to if there was actually any data moved. Maybe just a total number of items imported or something could be added? (In the Page Title import, it does include the number of records it would migrate before confirmation--something like that or, when importing, a bit of output that says what or how much was imported.) Just a thought.

Quick question: why do patches -32 and later remove the capability of importing path-based metatags quick data? I need to convert MTQ path-based settings to contexts.

@dmenefee: Maybe because Metatag on D8 doesn't have equivalent functionality yet?

Skip that, forgot this for D7 not D8.

I just used this on 7.x-1.22 and it worked great. We inherited a legacy d7 site that had metatag quick on it. Installed metatag, configured metatag, ran drush mtcmq = q'plah.

Thanks for all the reviews. Lets see if the patch still applies.

Anyone have time to do a quick reroll?

I had time, so here's a reroll.

Minor tweaks.

Further improvements, and now it outputs some status messages as it's working.

Committed. Thank you all for your help, I'm glad to finally have this committed.

Also, to @dmenefee - apologies for the snarkiness of my reply in #43, it was unnecessary.