imho, $data['entity_type']['translation_link'] definitions should be moved to Content translation module.

CommentFileSizeAuthor
#22 translation_link-2035587-22.patch4.32 KBvasike
#20 translation_link-2035587-20.patch4.13 KBvasike
#16 translation_link-2035587-16.patch4.12 KBvasike
#14 translation_link-2035587-14.patch4.12 KBvasike
#8 translation_link-2035587-8.patch4.13 KBvasike
#6 translation_link-2035587-6.patch4.11 KBvasike
#5 translation_link-2035587-5.patch4.24 KBvasike
#1 translation_link-2035587-1.patch4.02 KBvasike
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
translation_link-2035587-1.patch4.02 KB

here is patch for this.

i think this field needs a solution for the broken handler case, maybe #1825896: Add module owner to plugin data on handlers.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Active » Needs review

forgot the status change.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Issue tags: +D8MI, +VDC

and some tags

Status: Needs review » Needs work

The last submitted patch, translation_link-2035587-1.patch, failed testing.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review
FileSize
translation_link-2035587-5.patch4.24 KB

indeed the patch won't fit for user entities: they have "users" table name instead of "user".
i think it requires a fix for #140860: Consistent table names and database handling of table names.

but till then here is a new patch that deals with this issue.

p.s. other issue about the same users table #330983: Rename user module tables to singular.
probably there could be others issues, but the queue it's quite big.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
translation_link-2035587-6.patch4.11 KB

new patch

Status: Needs review » Needs work

The last submitted patch, translation_link-2035587-6.patch, failed testing.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review
FileSize
translation_link-2035587-8.patch4.13 KB

indeed. old code
new patch

Status: Needs review » Needs work

The last submitted patch, translation_link-2035587-8.patch, failed testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs work » Closed (works as designed)

I strongly disagree: the Content Translation module knows nothing about nodes, comments or any other entities. It's up to the single entity-defining modules to provide the integration code, exactly as they do for Views-related stuff. Aside from an architectural perspective, this won't scale as this way CT would be "responsible" to provide such code for any entity type out there.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Closed (works as designed) » Needs work

Sorry, if this can be done in a generic way I agree it should be in the CT module.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review

#8: translation_link-2035587-8.patch queued for re-testing.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Overall this looks good to me, thanks. I am not sure whether the current approach is the best way to detect entities, so I asked @timplunkett's feedback. Hope we'll hear from him soon :)

Meanwhile:

+++ b/core/modules/content_translation/content_translation.views.inc
@@ -0,0 +1,27 @@
+    // only Entities Views data that have translation enabled.

there is a missing capital letter (or an entire word?) here.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
translation_link-2035587-14.patch4.12 KB

update the help code.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented 
+++ b/core/modules/content_translation/content_translation.views.inc
@@ -0,0 +1,27 @@
+    // only for Entity Types that have translation enabled.

Missing capital still there.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
FileSize
translation_link-2035587-16.patch4.12 KB

i hope you meant the first letter from comment.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented

Yep, thanks. Still waiting for @timplunkett's feedback.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

+1

+++ b/core/modules/content_translation/content_translation.views.incundefined
@@ -0,0 +1,27 @@
+      // Content translation field.

I would skip that comment as it doesn't seem to add valuable information

+++ b/core/modules/content_translation/content_translation.views.incundefined
@@ -0,0 +1,27 @@
+        'help' => t('Provide a link to the translations overview for @entity_type_label.', array('@entity_type_label' => $table_info['table']['group'])),

I guess the entity type label should better be taken directly from the entity type.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Needs work
vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review
FileSize
translation_link-2035587-20.patch4.13 KB

@dawehner : imho the solution below should be just a temporary solution.
and the real solution should be a generic Views approach for Entities, where Views should know and use all the entities definitions for building the Views data, except too specific entities types data - no more hook_views_data() if possible, or in this case hook_views_data_alter() implementation.

p.s. : update the comment

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Needs work

Right (see #1740492: Implement a default entity views data handler), but the API freeze was like a while ago. Back to needs work based on my previous comment.

vasike’s picture

vasike
Location Ramnicu Valcea
CreditAttribution: vasike commented
Status: Needs work » Needs review
FileSize
translation_link-2035587-22.patch4.32 KB

i see and i'm sure that entity views data controller it will be implemented eventually.

here is a new patch that uses entity info data for entity type label.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Needs tests

Thank you very much! It seems to make sense to add a test to ensure that this code actually works.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
CreditAttribution: plach commented
Status: Needs review » Needs work

Looks good to me too but we are still missing tests.

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

quietone’s picture

quietone CreditAttribution: quietone at PreviousNext commented
Issue summary: View changes
Status: Needs work » Closed (duplicate)
Related issues: +#2322949: Implement generic entity link view field handlers

This was fixed in #2322949: Implement generic entity link view field handlers