Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Part of #1971384: [META] Convert page callbacks to controllers
For instructions on how to convert a page callback into a controller, see the WSCCI Conversion Guide.
Comment | File | Size | Author |
---|---|---|---|
#14 | interdiff.txt | 708 bytes | juampynr |
#14 | drupal-convert_menu_login_callback-1987734-14.patch | 3.14 KB | juampynr |
#9 | drupal-convert_menu_login_callback-1987734-9.patch | 3.04 KB | ramlev |
#3 | drupal-convert_menu_login_callback-1987734-3.patch | 2.96 KB | InternetDevels |
Comments
Comment #1
damiankloip CreditAttribution: damiankloip commentedI'll knock this one off the list.
Comment #2
InternetDevels CreditAttribution: InternetDevels commentedAs this issue hasn`t been fixed yet we are going to work on it today during Code Sprint UA
Comment #3
InternetDevels CreditAttribution: InternetDevels commentedPatch attached.
Comment #4
podarok#3 looks good
due to CodeSprintUA - bot overloaded and patch successfully run on dev server via all tests
If bot green - RTBC
Comment #6
RoSk0#3: drupal-convert_menu_login_callback-1987734-3.patch queued for re-testing.
Comment #7
dawehnerThis was just a random test error.
Comment #8
ramlev CreditAttribution: ramlev commentedComment #9
ramlev CreditAttribution: ramlev commentedRerolled the patch to work on 8.x
Comment #10
juampynr CreditAttribution: juampynr commentedMissing documentation blocks in this file, plus the class should implement ControllerInterface.
See https://drupal.org/node/1953346 for an example.
This needs a docblock.
Comment #11
juampynr CreditAttribution: juampynr commentedIgnore my comment above.
I wonder why this is not a controller and instead is a POPO. Shouldn't this implement ControllerInterface?
Comment #12
damiankloip CreditAttribution: damiankloip commentedI think this is fine, as you only really need ControllerInterface if you have dependencies you need to inject.
Comment #13
alexpottlet's remove the whole menu item here...
Comment #14
juampynr CreditAttribution: juampynr commentedHere you are.
Comment #15
dawehnerPerfect. Potentially you dropped the "()" but I don't care at all.
Comment #16
alexpottCommitted 35ab9ae and pushed to 8.x. Thanks!