Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
part of #2040105: [meta] Implement LocalTask plugins for previously converted routes
follow-up to #2004334: Separate Tabs (MENU_LOCAL_TASK) from hook_menu()
The login/new password/register tabs need to be converted to plugins.
Comment | File | Size | Author |
---|---|---|---|
#15 | user_local_task-2044539-15.patch | 2.83 KB | dawehner |
#15 | interdiff.txt | 1.35 KB | dawehner |
#13 | user_tasks-2044539-13.patch | 1.48 KB | dawehner |
#10 | user-2044539-10.patch | 4.11 KB | dawehner |
#4 | 2044539-4.patch | 7.23 KB | pwolanin |
Comments
Comment #1
pwolanin CreditAttribution: pwolanin commentedsimple conversion
Comment #3
pwolanin CreditAttribution: pwolanin commentedPartial fix - also looks like this requires #2031353: URLgenerator broken for Drupal installed in a subdirectory - doesn't have a way to get a Drupal path So I expect a couple fails.
Comment #4
pwolanin CreditAttribution: pwolanin commentedThis fixes the base plugin - we should have just have been pulling the path from the route patten, as we did earlier in the issue where that class was created, instead of trying to use the generator since the base plugin doesn't handle dynamic paths.
Comment #5
pwolanin CreditAttribution: pwolanin commentedtagging
Comment #6
janNelx adsasda CreditAttribution: janNelx adsasda commentedI had the problem but it works now
Comment #7
dawehnerAs written in IRC this is a step backwards, as we would have to use the generate method in the future again.
I guess we should not remove that feature?
Comment #8
pwolanin CreditAttribution: pwolanin commented@dawehner - it would still be possible to add sub-tabs below login, it just doesn't require this hack of an extra default local task.
Comment #9
pwolanin CreditAttribution: pwolanin commented@dawehner - if we want to use the generator rather than the simple static pattern, then this conversion is blocked these 2 issue I think:
#2031353: URLgenerator broken for Drupal installed in a subdirectory - doesn't have a way to get a Drupal path
#2031487: When replacing the upcasted values in the request attributes array, retain the original raw value too
Comment #10
dawehnerRerolled the patch without the changes in the local action manager.
Comment #12
dawehnerThis currently fails because the path with enabled language like /en/user/password. Given this path to menu_item_route_access() fails.
The proper solution for this problem is #2046737: Add a method to the AccessManager that only needs a route name and parameters
Comment #13
dawehnerRerolled against recent yml discovery.
Comment #15
dawehnerFixed some of the failures.
Comment #17
dawehnerThis is all covered by #2102125: Big Local Task Conversion