Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Follow up for #1971384: [META] Convert page callbacks to controllers
Comment | File | Size | Author |
---|---|---|---|
#24 | interdiff.txt | 1.44 KB | tim.plunkett |
#22 | custom-block-1983682-22.patch | 11.31 KB | tim.plunkett |
#22 | interdiff.txt | 11.5 KB | tim.plunkett |
#18 | custom_block-1983682-18.patch | 11.5 KB | tim.plunkett |
#18 | interdiff.txt | 5.26 KB | tim.plunkett |
Comments
Comment #1
larowlan_entity_form is awesome!
less code++
Comment #3
tim.plunkettSwooping in :)
Comment #5
tim.plunkettThis is blocked by #1987344: NotFoundHttpException thrown in ParamConverterManager results in a WSOD at least.
Comment #7
tim.plunkettBlocks #1908756: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu()
Comment #8
dawehnerI guess this should be moved into a separate issue.
Oh does this regex support come from symfony directly, neat.
Comment #9
tim.plunkettThat got moved out into #1987344: NotFoundHttpException thrown in ParamConverterManager results in a WSOD which went in.
Rerolled and updated for #1908756: Separate Action Links (MENU_LOCAL_ACTION) from hook_menu().
Comment #11
tim.plunkettMissed a spot.
Comment #13
h3rj4n CreditAttribution: h3rj4n commentedre-rolled the patch. Tested locally but failed on the 'Custom Block translation UI' test. A verbose message gave me this:
InvalidArgumentException: Missing 'form: default' for entity 'custom_block' in Drupal\Core\Entity\EntityManager->getControllerClass() (line 166 of /var/www/html/drupal/core/lib/Drupal/Core/Entity/EntityManager.php).
It still has to do something with routing.
Comment #14
tim.plunkettTrailing whitespace
You can't get rid of "default" anymore until #2006348: Remove default/fallback entity form operation goes in.
Comment #15
h3rj4n CreditAttribution: h3rj4n commentedAdded the 'default' in the file. Didn't found the white pace error.
The test still fails. Dunno why. Tried to add a custom block manually in a different language and I got the following error:
Comment #16
tim.plunkettComment #18
tim.plunkettWrong form controller.
Also leftover code in custom_block.admin.inc.
Comment #20
tim.plunkett#18: custom_block-1983682-18.patch queued for re-testing.
Comment #21
larowlanI think this will double encode (ie two calls to check_plain, one from drupal_set_title, one from using @)
Other than that looks RTBC
Comment #22
tim.plunkettAh that was a hack anyway, we fixed title callback for routes.
Comment #24
tim.plunkettWrong interdiff
Comment #25
larowlanUnless bot says no
Comment #26
catch#22: custom-block-1983682-22.patch queued for re-testing.
Comment #27
alexpottAre we sure that we want to use this route for editing a block? What about sub-requests / ESI etc...
Comment #28
tim.plunkettIs that in scope?
is in HEAD, this is just a conversion.
Comment #29
alexpottYou're correct - it's out of scope :)
Committed c2e0cda and pushed to 8.x. Thanks!