Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

vijaycs85’s picture

Status: Active » Postponed

Blocked by #1978166: Convert block/add/{%custom_block_type} to Controller as it has support for default value.

andypost’s picture

Status: Postponed » Active

Not blocked anymore

tim.plunkett’s picture

Status: Active » Needs review
FileSize
4.61 KB

This needs a new access checker, but I just wanted to get the start of it up.

Status: Needs review » Needs work

The last submitted patch, taxonomy-1987860-4.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
FileSize
4.88 KB
6.89 KB

Hopefully #2028585: Replace entity_page_create_access by an access controller will replace entity_page_create_access(), but we should continue using it for now.

vijaycs85’s picture

looks good to me. RTBC from my side.

andypost’s picture

#6: taxonomy-1987860-6.patch queued for re-testing.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Great!

tim.plunkett’s picture

Status: Reviewed & tested by the community » Needs review
FileSize
3.72 KB
8.26 KB

Status: Needs review » Needs work
Issue tags: -WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-10.patch, failed testing.

ParisLiakos’s picture

Status: Needs work » Needs review
Issue tags: +WSCCI-conversion, +MENU_LOCAL_ACTION

#10: taxonomy-1987860-10.patch queued for re-testing.

tim.plunkett’s picture

FileSize
6.93 KB

That went in.

dawehner’s picture

+++ b/core/modules/taxonomy/lib/Drupal/taxonomy/Access/TaxonomyTermCreateAccess.phpundefined
@@ -0,0 +1,34 @@
+ * Contains Drupal\taxonomy\Access\TaxonomyTermCreateAccess.

Missing "\"

tim.plunkett’s picture

FileSize
569 bytes
6.93 KB

:)

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Perfect

Status: Reviewed & tested by the community » Needs work
Issue tags: -WSCCI-conversion, -MENU_LOCAL_ACTION

The last submitted patch, taxonomy-1987860-15.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Needs review
Issue tags: +WSCCI-conversion, +MENU_LOCAL_ACTION

#15: taxonomy-1987860-15.patch queued for re-testing.

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community
YesCT’s picture

Issue tags: +RTBC July 1

This issue was RTBC and passing tests on July 1, the beginning of API freeze.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 67ffbd3 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture