Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Remaining:
- system.schema.yml
a. system.rss - image.schema.yml
- picture mappings
- date formats
Comment | File | Size | Author |
---|---|---|---|
#34 | image-styles.png | 194.84 KB | YesCT |
#33 | 2044387-config-translation-imagestyles-33.patch | 909 bytes | YesCT |
#23 | core-fixed.patch | 3.16 KB | Gábor Hojtsy |
#21 | interdiff.txt | 1.93 KB | Gábor Hojtsy |
#21 | 2044387-config-translation-rss-image-20.patch | 7.86 KB | Gábor Hojtsy |
Comments
Comment #1
vijaycs85Initial patch with screenshot...
Comment #2
vijaycs85Adding tag to extend test cases.
Comment #3
Gábor HojtsyLooking at this.
Comment #4
Gábor HojtsyAdding tests. Also moved around mappers in alphabetical order. I can live with that in this patch :)
Comment #6
Gábor HojtsyFound in #2044389: [META] Fix broken configuration translation pages that picture mapping also need to be supported. That is however blocked on another core issue I just found, see #2044865: Picture mappings cannot be edited. Added the picture mapper anyway here. No tests for that yet, since that would require #2044865: Picture mappings cannot be edited to land to pass.
Comment #8
Gábor HojtsyThe image style related fail is due to #1809376: Use EntityListController for image styles, the current image style listing operations are not possible to alter. So we'll need to not try to test for what cannot be there for a while.
Comment #9
Gábor HojtsyAdd tests snippet for picture listing stuff.
Comment #11
Gábor HojtsyThe picture message assert was bad. Fixing that and adding date formats too :) This will fail as well due to #2038285: Update configuration schema for date formats as entities.
Comment #13
Gábor HojtsyMake date format tests actually run. Uncomment failing test which we know is due to core issue. Add core issue link.
Comment #15
Gábor HojtsySo this uncovers that date format translate page does not work due to #2038285: Update configuration schema for date formats as entities, commenting that one out with todo as well.
Comment #16
Gábor HojtsyActual patch.
Comment #18
Gábor HojtsyThere may be more failures around date stuff, let's comment this out for now.
Comment #20
Gábor HojtsyThe notice was actually for the picture page which my core patch resolves, so I could not reproduce locally due to that patch applied. Reproduced now, commenting that out too.. Heh.
Comment #21
Gábor HojtsyComment #22
Gábor HojtsyCommitted this for now. The @todo's will be taken care of later. They are clearly marked.
Comment #23
Gábor HojtsySome core fixes landed in the meantime. Let's try to activate those tests :)
Comment #24
Gábor HojtsyComment #25
Gábor HojtsyAll right, committed and pushed that one.
Comment #26
YesCT CreditAttribution: YesCT commentedwe still have this @todo for #1809376: Use EntityListController for image styles So lets keep this open for that.
[edited to correct the in code link]
Comment #27
tstoecklerThat issue link is wrong, does anyone know where that is supposed to point?
Comment #28
Gábor Hojtsy#1809376: Use EntityListController for image styles is the right one as pointed out by @YesCT. The last number got lost for some reason in her quoted code. AFAIS the codebase has the right issue number/link too. So not sure how it got removed there...
Comment #29
tstoecklerAhh, thanks. I should remember to actually *read* comments.... *slapsforehead*
Comment #30
Gábor HojtsyThe image styles issue is now merged into #1788542: Use EntityFormController and EntityListController for image styles.
Comment #31
Gábor HojtsyImage style controllers landed, so let's close the loop here :)
Comment #32
YesCT CreditAttribution: YesCT commentedI'll do it. k?
Comment #33
YesCT CreditAttribution: YesCT commenteddidn't test this locally.
Comment #34
YesCT CreditAttribution: YesCT commentedwithout the patch link
[edit: oops without, I just forgot to turn on config translation. so the translate link is showing, lets just see how the tests come back. Should we look at something else?]
with:
:)
Comment #36
Gábor HojtsyLooks like a great patch! The fail is unrelated, but would ideally need to be fixed first, so we can ensure the module passes. Looks like the shortcut entity was renamed? Probably needs a quick new issue.
Comment #37
YesCT CreditAttribution: YesCT commentedok. :)
#2054183: shortcut renamed
Comment #38
YesCT CreditAttribution: YesCT commented#33: 2044387-config-translation-imagestyles-33.patch queued for re-testing.
Comment #39
Gábor HojtsyYay, committed this patch then! Should be possible to close this down.
Comment #40.0
(not verified) CreditAttribution: commentedUpdated issue summary.