Follow up for #1953404: Add config schema to field and instance config entities
Part of #1983894: Provide config schema to field types and storage in email module
Problem/motivation
#1866610: Introduce Kwalify-inspired schema format for configuration introduced the idea of config schema. The changelog leads to (hopefully extensive) documentation on the format at http://drupal.org/node/1905070. As a part of schema addition to field module(#1953404: Add config schema to field and instance config entities), found that we have to provide schema for field types, field widgets and field storage.
Proposed solution
Create a configuration schema for field types, field widget and field storage (if applicable) defined in email module.
Schema in place
Schema not in place
field.email.settings
field.email.instance_settings
field.email.value
field_widget.email_default.settings
Comment | File | Size | Author |
---|---|---|---|
#13 | 1983894-field-config-schema-email-13.patch | 751 bytes | vijaycs85 |
#13 | 1983894-diff-6-13.txt | 620 bytes | vijaycs85 |
#9 | s01-default-first-try.png | 438.14 KB | YesCT |
#6 | email-config-schema-1983894-6.patch | 802 bytes | hussainweb |
#3 | 1983894-config-schema-email-removed-email-widget.patch | 2.6 KB | swastik1608 |
Comments
Comment #1
vijaycs85Initial patch with config inspector screenshots.
Comment #2
swentel CreditAttribution: swentel commentedWidget needs to go out after #1875992: Add EntityFormDisplay objects for entity forms got in.
Comment #3
swastik1608 CreditAttribution: swastik1608 commentedremoved email widget settings form 1983894-field-config-schema-email-1.patch file
Comment #5
hussainwebThe patch in #3 appears to be of a completely different issue. It doesn't look related to anything in #1.
Comment #6
hussainwebI am basing off the changes from the work in #1983906: Provide config schema to field types and storage in link module. I am hoping this works.
Comment #7
neetu morwani CreditAttribution: neetu morwani commentedI created the patch first.Provided the schema for the configuration files of the Email module.Enabled the email module and added the field "email" to a content type.Then checked the value of the field type "email" with the valid and invalid values.Everything is working fine as expected.
Comment #8
neetu morwani CreditAttribution: neetu morwani commentedComment #9
YesCT CreditAttribution: YesCT commentedIf testing this,
be sure to enable the
E-mail
module
I added an email field (named myemail) to article
so could look at
http://localhost/drupal2/admin/reports/config-inspector/field.instance.n...
and
http://localhost/drupal2/admin/reports/config-inspector/field.field.fiel...
and I can see the default settings have an effect
but I'm having trouble seeing the other bits,
so I added an email field at
http://localhost/drupal2/admin/config/people/accounts
but I stil dont see those. how did you get "Email settings"?
Comment #10
alexpottCan some answer YesCT's question from the review in #9... how did you get "Email settings"?
Actually I know this is wrong now because we no longer have the 'Display on user registration form" code because we now do this with form display modes :)
Comment #11
hussainwebI wish I had read the comment in #10 in detail. I spent quite some time analyzing what would that 'user_register_form' do only to realize it doesn't seem to be doing anything anymore. I was going to post another patch with that block removed, which led to a problem.
Once we remove the 'user_register_form' setting, there is nothing else in the instance_settings field. Should we let it stay anyway? This way:
Or should we remove this block entirely?
Comment #12
hussainwebAnd to respond to the question in #9, the
field.email.settings
block (marked in orange) is seen in the right-most screenshot close to the bottom (just below the 'Default value function' text box. It is empty because nothing has been stored in that setting. I confirmed this with config inspector screens for other field instances as well.Comment #13
vijaycs85Adding changes for #11.
Comment #14
nils.destoop CreditAttribution: nils.destoop commentedWas going to review this one. But then i bounced on this issue #2053245: Default value of email field is not saved anymore.
The patch looks good, but will wait to set this to RTBC when i can validate it with config inspector.
Comment #15
yanniboi CreditAttribution: yanniboi commentedI will have a look at this.
Comment #16
nils.destoop CreditAttribution: nils.destoop commentedLooks good to me.
Comment #17
Hydra CreditAttribution: Hydra commented#13: 1983894-field-config-schema-email-13.patch queued for re-testing.
Comment #18
webchickCommitted and pushed to 8.x. Thanks!
Comment #19.0
(not verified) CreditAttribution: commentedMissing link to meta