Aggregator Category blocks do not render

The patch as promised. :)

Great, its green. The test for this is in the patch in #2031859-49: Invoke an event[s] when a plugin ID disappears.

Yes, and the tests are a part of the patch in #2031859-49: Invoke an event[s] when a plugin ID disappears:

+
+    // Place the category 2 block.
+
+    // Clear the block cache to load the new block definitions.
+    $this->container->get('plugin.manager.block')->clearCachedDefinitions();
+
+    // Need admin user to be able to access block admin.
+    $admin_user = $this->drupalCreateUser(array(
+      'administer blocks',
+      'access administration pages',
+      'administer news feeds',
+      'access news feeds',
+      'create article content',
+    ));
+    $this->drupalLogin($admin_user);
+
+    $block = $this->drupalPlaceBlock("aggregator_category_block:{$category_2_record->cid}", array('label' => 'category-' . $category_2_new_title, 'block_count' => 2));
+
+    // The block should not appear as there are no feed items.
+    $this->drupalGet('test-page');
+    $this->assertNoText($block->label(), format_string('Feed Category block %label is not displayed on the page.', array('%label' => $block->label())));
+
+    // Create some nodes and update the feed items.
+    $this->createSampleNodes();
+    $this->updateFeedItems($db_feed, $this->getDefaultFeedItemCount());
+
+    // The block should appear now.
+    $this->drupalGet('test-page');
+    $this->assertText($block->label(), format_string('Feed Category block %label is displayed on the page.', array('%label' => $block->label())));

It is not just a matter of convenience. The test is necessary for that issue as well. If I have to put the test in this commit, then it means that we have to wait for this to get committed, then reroll the patch in #2031859-49: Invoke an event[s] when a plugin ID disappears. Just introduces more work. Is that necessary? I mean, the tests are there.

Let me know what you think.

Attaching just a small tweak in the comment, for better clarity.

If those two are the only choices we have, then I think I'd prefer adding tests here. The issue here is only tangential to the issue in #2031859: Invoke an event[s] when a plugin ID disappears.

I would still say to just commit it here and wait for the tests in the other issue, as it becomes a consolidated fix (and the test is really valid there too). I see the point in adding tests here, but it is just extra work. :)